fix: resolve WCAG AA color contrast violations#301
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 18, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
tomasz-tomczyk
added a commit
that referenced
this pull request
Apr 20, 2026
…engthen CSS guardrails The WCAG fix (#301) introduced a regression: --fg-on-accent was removed from [data-theme="light"], causing btn-primary text to be unreadable (dark navy on dark blue) when users explicitly select Light theme. Also removes dead --btn-primary-bg/fg/border vars (defined but never referenced) and dead --bg-gutter var found by the strengthened script. Strengthens check-css-vars.sh with two new checks: - Dead definitions: vars defined but never referenced via var() - 4-block completeness: theme vars must appear in all 4 theme blocks Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Merged
4 tasks
tomasz-tomczyk
added a commit
that referenced
this pull request
Apr 20, 2026
…engthen CSS guardrails (#315) The WCAG fix (#301) introduced a regression: --fg-on-accent was removed from [data-theme="light"], causing btn-primary text to be unreadable (dark navy on dark blue) when users explicitly select Light theme. Also removes dead --btn-primary-bg/fg/border vars (defined but never referenced) and dead --bg-gutter var found by the strengthened script. Strengthens check-css-vars.sh with two new checks: - Dead definitions: vars defined but never referenced via var() - 4-block completeness: theme vars must appear in all 4 theme blocks Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--fg-mutedand--fg-dimmedfor readable toggle buttons and gutter numberscolor-contrastaxe-core rule + add dark theme accessibility testReview
Test plan
npx playwright test tests/accessibility.spec.ts— passes both light and darknpx playwright test tests/theme.spec.ts tests/syntax-highlighting.spec.ts— 12/12 passmake test-diffCloses #274
See also: tomasz-tomczyk/crit-web#90 — parity follow-up
🤖 Generated with Claude Code