fix: add missing --fg-on-accent to light theme, remove dead vars, strengthen CSS guardrails#315
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
…engthen CSS guardrails The WCAG fix (#301) introduced a regression: --fg-on-accent was removed from [data-theme="light"], causing btn-primary text to be unreadable (dark navy on dark blue) when users explicitly select Light theme. Also removes dead --btn-primary-bg/fg/border vars (defined but never referenced) and dead --bg-gutter var found by the strengthened script. Strengthens check-css-vars.sh with two new checks: - Dead definitions: vars defined but never referenced via var() - 4-block completeness: theme vars must appear in all 4 theme blocks Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--fg-on-accentregression from fix: resolve WCAG AA color contrast violations #301: missing from[data-theme="light"]block, causing unreadable btn-primary text (dark navy on dark blue) when users explicitly select Light theme--btn-primary-bg/fg/bordervars (defined but never referenced — debris from fix: resolve WCAG AA color contrast violations #301)--bg-guttervar (defined in all 4 blocks, referenced nowhere)check-css-vars.shwith two new checks: dead-definition detection and 4-block completeness verificationTest plan
bash scripts/check-css-vars.sh— should pass🤖 Generated with Claude Code