Skip to content

Features/provider specific params#90

Merged
eschrock merged 37 commits intotitan-data:masterfrom
mcred:features/provider-specific-params
Oct 29, 2019
Merged

Features/provider specific params#90
eschrock merged 37 commits intotitan-data:masterfrom
mcred:features/provider-specific-params

Conversation

@mcred
Copy link
Collaborator

@mcred mcred commented Oct 29, 2019

Issues Addressed

Fixes #20

Proposed Changes

Add -p, --parameters option to the CLI commands, pass these values to the remove providers.

Testing

 vexrun -f ./src/endtoend-test/remotes/ssh/sshWorkflowTests.yml
get ssh test server: PASSED
start ssh server: PASSED
create test directory in ssh server: PASSED
get localhost ip: PASSED
run empty mongo db: PASSED
create new commit: PASSED
add ssh remote with password succeeds: PASSED
repo has ssh remote with password: PASSED
list remote with password commits returns empty list: FAILED
Result(exitValue=1, stdout=Command failed: Warning: Permanently added '172.16.168.147' (ECDSA) to the list of known hosts.
ls: cannot access '/test': No such file or directory, stderr=)
get non-existent remote commit with password fails: PASSED
push commit with password succeeds: PASSED
list remote commits with password returns pushed commit: PASSED
push of same commit with password fails: PASSED
delete local commit succeeds: PASSED
list local commits is empty: PASSED
pull original commit with password succeeds: PASSED
checkout commit succeeds: PASSED
remove remote with password succeeds: PASSED
create new sshkey commit: PASSED
create new directory in ssh server: PASSED
add private ssh key to ssh server: PASSED
add remote with ssh key succeeds: PASSED
repo has ssh remote with ssh key: PASSED
list remote with ssh key commits returns empty list: FAILED
Result(exitValue=1, stdout=Command failed: Warning: Permanently added '172.16.168.147' (ECDSA) to the list of known hosts.
ls: cannot access '/sshtest': No such file or directory, stderr=)
get non-existent remote commit with ssh key fails: PASSED
push commit with ssh key succeeds: PASSED
list remote commits with ssh key returns pushed commit: PASSED
push of same commit with ssh key fails: PASSED
delete local commit succeeds: PASSED
list local commits is empty: PASSED
pull original commit with ssh key succeeds: PASSED
checkout commit succeeds: PASSED
remove remote with ssh key succeeds: PASSED
remove sshTest succeeds: PASSED
stop ssh server: PASSED

Derek Smart and others added 30 commits September 18, 2019 10:58
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Github Actions with minor fixes (#11)
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Derek Smart added 4 commits October 29, 2019 12:00
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
@mcred mcred requested a review from a team as a code owner October 29, 2019 17:05
Derek Smart added 3 commits October 29, 2019 13:07
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
@eschrock eschrock merged commit 732e129 into titan-data:master Oct 29, 2019
mcred pushed a commit to mcred/titan that referenced this pull request Oct 29, 2019
@mcred mcred deleted the features/provider-specific-params branch October 29, 2019 21:41
mcred pushed a commit to mcred/titan that referenced this pull request Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add provider specific settings

2 participants