Skip to content

Feature/e2e framework#86

Merged
eschrock merged 2 commits intotitan-data:masterfrom
mcred:feature/e2e-framework
Oct 24, 2019
Merged

Feature/e2e framework#86
eschrock merged 2 commits intotitan-data:masterfrom
mcred:feature/e2e-framework

Conversation

@mcred
Copy link
Collaborator

@mcred mcred commented Oct 24, 2019

Issues Addressed

Sets up the end to end test framework

Proposed Changes

yaml files and readme for writing and running end to end test

Testing

Run locally.

mcred and others added 2 commits October 23, 2019 22:57
Signed-off-by: Derek Smart <derek.smart@delphix.com>
@mcred mcred requested a review from a team as a code owner October 24, 2019 03:00
Copy link
Contributor

@eschrock eschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: make "exitValue: 0" the default. Most of the time you're going to want your commands to succeed.

@eschrock eschrock merged commit a5e28d7 into titan-data:master Oct 24, 2019
mcred added a commit to mcred/titan that referenced this pull request Oct 25, 2019
mcred pushed a commit to mcred/titan that referenced this pull request Oct 29, 2019
@mcred mcred deleted the feature/e2e-framework branch October 29, 2019 21:41
mcred pushed a commit to mcred/titan that referenced this pull request Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants