Skip to content

server: add a raft messgae flush metrics#2771

Merged
siddontang merged 3 commits intotikv:masterfrom
siddontang:siddontang/metric
Mar 1, 2018
Merged

server: add a raft messgae flush metrics#2771
siddontang merged 3 commits intotikv:masterfrom
siddontang:siddontang/metric

Conversation

@siddontang
Copy link
Contributor

Add a counter to know the flush frequency.

Will add the Grafana later.

PTAL @ngaut @disksing

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@disksing disksing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@siddontang siddontang merged commit 34614fc into tikv:master Mar 1, 2018
@siddontang siddontang deleted the siddontang/metric branch March 1, 2018 02:41
sticnarf pushed a commit to sticnarf/tikv that referenced this pull request Oct 27, 2019
bufferflies pushed a commit to bufferflies/tikv that referenced this pull request Sep 19, 2025
* concurrency_manager: check update_max_ts against a limit (tikv#17917)

close tikv#17916

concurrency_manager: add safety boundary for max_ts updates

Add `max_ts_limit` to prevent unreasonable timestamp updates. The limit is
synchronized with PD timestamp periodically. Configure via max_ts_allowance_secs
 and max_ts_sync_interval_secs.

Updates from PD bypass this limit.

Signed-off-by: ekexium <eke@fastmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: ekexium <eke@fastmail.com>

* concurrency_manager: double check via PD TSO before reporting error of invalid max-ts update (tikv#18057)

close tikv#18055

concurrency_manager: double check via PD TSO before reporting error of invalid max-ts update

Signed-off-by: ekexium <eke@fastmail.com>

* concurrency_manager: make max-ts checker more robust (tikv#18080)

ref tikv#18055

When validating max-ts updates, do not report error or panic unless confirmed by PD TSO.
This reduces both false positive and false negative cases.

Signed-off-by: ekexium <eke@fastmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: ekexium <eke@fastmail.com>

* config: rename config items for max-ts checker (tikv#18118)

ref tikv#17916

config: rename config items for max-ts checker

Signed-off-by: ekexium <eke@fastmail.com>

* concurrency-manager: do not assert in concurrency manager (tikv#18329)

ref tikv#17916

Do not assert in concurrency manager.

Signed-off-by: ekexium <eke@fastmail.com>

* delete unexpected files from cherry-picking

Signed-off-by: ekexium <eke@fastmail.com>

---------

Signed-off-by: ekexium <eke@fastmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants