concurrency-manager: do not assert in concurrency manager#18329
Merged
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom Mar 21, 2025
Merged
concurrency-manager: do not assert in concurrency manager#18329ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
Conversation
Signed-off-by: ekexium <eke@fastmail.com>
zyguan
approved these changes
Mar 21, 2025
cfzjywxk
approved these changes
Mar 21, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, zyguan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Member
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tikv
that referenced
this pull request
Mar 21, 2025
ref tikv#17916 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
9 tasks
Member
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tikv
that referenced
this pull request
Mar 21, 2025
ref tikv#17916 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
9 tasks
bufferflies
pushed a commit
to bufferflies/tikv
that referenced
this pull request
Sep 19, 2025
* concurrency_manager: check update_max_ts against a limit (tikv#17917) close tikv#17916 concurrency_manager: add safety boundary for max_ts updates Add `max_ts_limit` to prevent unreasonable timestamp updates. The limit is synchronized with PD timestamp periodically. Configure via max_ts_allowance_secs and max_ts_sync_interval_secs. Updates from PD bypass this limit. Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Signed-off-by: ekexium <eke@fastmail.com> * concurrency_manager: double check via PD TSO before reporting error of invalid max-ts update (tikv#18057) close tikv#18055 concurrency_manager: double check via PD TSO before reporting error of invalid max-ts update Signed-off-by: ekexium <eke@fastmail.com> * concurrency_manager: make max-ts checker more robust (tikv#18080) ref tikv#18055 When validating max-ts updates, do not report error or panic unless confirmed by PD TSO. This reduces both false positive and false negative cases. Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Signed-off-by: ekexium <eke@fastmail.com> * config: rename config items for max-ts checker (tikv#18118) ref tikv#17916 config: rename config items for max-ts checker Signed-off-by: ekexium <eke@fastmail.com> * concurrency-manager: do not assert in concurrency manager (tikv#18329) ref tikv#17916 Do not assert in concurrency manager. Signed-off-by: ekexium <eke@fastmail.com> * delete unexpected files from cherry-picking Signed-off-by: ekexium <eke@fastmail.com> --------- Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Issue Number: ref #17916
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note