compact_log_backup: optimize compact#18882
Merged
ti-chi-bot[bot] merged 21 commits intotikv:masterfrom Oct 27, 2025
Merged
Conversation
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
d0e6115 to
2c8e918
Compare
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
1894a62 to
f138f18
Compare
Signed-off-by: Jianjun Liao <36503113+Leavrth@users.noreply.github.com>
YuJuncen
approved these changes
Oct 22, 2025
Signed-off-by: Jianjun Liao <36503113+Leavrth@users.noreply.github.com>
3pointer
reviewed
Oct 27, 2025
| let exp = self.expiring(&item); | ||
| if !exp.is_empty() { | ||
| result.push(exp); | ||
| if item.min_ts <= until_ts { |
Contributor
There was a problem hiding this comment.
what's the meaning of min_ts here? should we check max_ts too ?
Contributor
Author
There was a problem hiding this comment.
if min_ts of the metadata file is larger than the compaction task until_ts, no kv will be chosen to compact. Therefore, there is no need to record it into migration.
Contributor
There was a problem hiding this comment.
If so, I think we can filter metadata not only check byts but also by key range span in the expiring.
Maybe we can do it in another PR.
3pointer
approved these changes
Oct 27, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Contributor
Author
|
/retest |
Contributor
Author
|
/ok-to-test |
YuJuncen
added a commit
to YuJuncen/tikv
that referenced
this pull request
Dec 5, 2025
close tikv#18843, close tikv#18950 1. Remove read_buf_exact_size for s3 hyper client 2. Use cloud::blob::read_to_end to read migrations from futures::io::AsyncRead 3. Use bytes::Bytes to speed up deallocating MetaFile Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com> Signed-off-by: Jianjun Liao <36503113+Leavrth@users.noreply.github.com> Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
YuJuncen
added a commit
to YuJuncen/tikv
that referenced
this pull request
Dec 5, 2025
close tikv#18843, close tikv#18950 1. Remove read_buf_exact_size for s3 hyper client 2. Use cloud::blob::read_to_end to read migrations from futures::io::AsyncRead 3. Use bytes::Bytes to speed up deallocating MetaFile Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com> Signed-off-by: Jianjun Liao <36503113+Leavrth@users.noreply.github.com> Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
9 tasks
YuJuncen
added a commit
that referenced
this pull request
Dec 5, 2025
* compact_log_backup: optimize compact (#18882) close #18843, close #18950 1. Remove read_buf_exact_size for s3 hyper client 2. Use cloud::blob::read_to_end to read migrations from futures::io::AsyncRead 3. Use bytes::Bytes to speed up deallocating MetaFile Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com> Signed-off-by: Jianjun Liao <36503113+Leavrth@users.noreply.github.com> Signed-off-by: Juncen Yu <yujuncen@pingcap.com> * mute clippy Signed-off-by: Juncen Yu <yujuncen@pingcap.com> * make format Signed-off-by: Juncen Yu <yujuncen@pingcap.com> --------- Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com> Signed-off-by: Jianjun Liao <36503113+Leavrth@users.noreply.github.com> Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Issue Number: Close #18843, Close #18950
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note