Skip to content

compact_log_backup: optimize compact (#18882)#19168

Merged
YuJuncen merged 3 commits intotikv:release-8.5-20251126-v8.5.4from
YuJuncen:release-8.5-20251126-v8.5.4
Dec 5, 2025
Merged

compact_log_backup: optimize compact (#18882)#19168
YuJuncen merged 3 commits intotikv:release-8.5-20251126-v8.5.4from
YuJuncen:release-8.5-20251126-v8.5.4

Conversation

@YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Dec 5, 2025

close #18843, close #18950

  1. Remove read_buf_exact_size for s3 hyper client
  2. Use cloud::blob::read_to_end to read migrations from futures::io::AsyncRead
  3. Use bytes::Bytes to speed up deallocating MetaFile

What is changed and how it works?

Issue Number: Close #xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@YuJuncen
compact_log_backup: optimize compact (tikv#18882)
7104f34 
close tikv#18843, close tikv#18950

1. Remove read_buf_exact_size for s3 hyper client
2. Use cloud::blob::read_to_end to read migrations from futures::io::AsyncRead
3. Use bytes::Bytes to speed up deallocating MetaFile

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <36503113+Leavrth@users.noreply.github.com>
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Dec 5, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign coocood for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 5, 2025
@YuJuncen
mute clippy
89a8848 
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
@YuJuncen
make format
08e2afc 
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Dec 5, 2025

/test pull-unit-test

@YuJuncen YuJuncen merged commit 96af5c6 into tikv:release-8.5-20251126-v8.5.4 Dec 5, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@YuJuncen