Skip to content

cargo: update async-compression#18841

Merged
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
3pointer:fix_zstd_log_backup
Aug 18, 2025
Merged

cargo: update async-compression#18841
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
3pointer:fix_zstd_log_backup

Conversation

@3pointer
Copy link
Contributor

@3pointer 3pointer commented Aug 18, 2025 •
edited
Loading

What is changed and how it works?

Issue Number: Close #18836

What's Changed:

cargo: update async-compression

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    With tpcc default bench worklaod

Before this PR
image

After this PR
image

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fix the issue where Zstd compression did not take effect in log backup, resulting in uncompressed output.

@3pointer
cargo: update async-compression
1891c3a 
Signed-off-by: 3pointer <luancheng@pingcap.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-triage-completed dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2025
@3pointer 3pointer marked this pull request as ready for review August 18, 2025 03:11
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 18, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 18, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-18 03:12:55.775159112 +0000 UTC m=+236783.718334629: ☑️ agreed by YuJuncen.
  • 2025-08-18 03:15:27.284922925 +0000 UTC m=+236935.228098431: ☑️ agreed by Leavrth.

@3pointer
update cargo.toml
632fb8e 
Signed-off-by: 3pointer <luancheng@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2025
@ti-chi-bot ti-chi-bot bot merged commit 8dc4ac7 into tikv:master Aug 18, 2025
8 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Aug 18, 2025
@3pointer 3pointer removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved labels Aug 28, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2025

@3pointer: You cannot manually add or delete the reviewing state labels, only I and the tursted members have permission to do so.

Details

In response to removing label named approved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 28, 2025
@3pointer 3pointer added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Aug 28, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Aug 28, 2025
@3pointer @ti-chi-bot
This is an automated cherry-pick of tikv#18841
8f86147 
close tikv#18836

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 28, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #18883.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 28, 2025
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Aug 28, 2025
@ti-chi-bot @3pointer
cargo: update async-compression (#18841) (#18883)
4d810f7 
close #18836

cargo: update async-compression

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: 3pointer <luancheng@pingcap.com>

Co-authored-by: 3pointer <luancheng@pingcap.com>
3AceShowHand pushed a commit to 3AceShowHand/tikv that referenced this pull request Oct 13, 2025
@3pointer @3AceShowHand
cargo: update async-compression (tikv#18841)
9b20c9b 
close tikv#18836

cargo: update async-compression

Signed-off-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

+1 more reviewer

@Leavrth Leavrth Leavrth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

Log backup zstd compression ineffective after async-compression v0.4.12 upgrade

4 participants

@3pointer @ti-chi-bot @YuJuncen @Leavrth