Skip to content

Log backup zstd compression ineffective after async-compression v0.4.12 upgrade #18836

@3pointer

Description

@3pointer

Bug Report

What version of TiKV are you using?

v8.5(after this PR merged. async-compression upgrade from v0.3.14 to v0.4.12 introduce this issue).

What operating system and CPU are you using?

N/A

Steps to reproduce

Run log backup where the default compression algorithm is expected to be zstd fastest.
After upgrading async-compression to v0.4.12, the issue described in Nullus157/async-compression#352 can be reproduced.

What did you expect?

zstd compression works correctly with the intended fastest setting.

What did happened?

In async-compression v0.4.12, the default zstd compression level was incorrectly set to a negative value, causing zstd compression to be disabled or ineffective.

Image Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    affects-8.5This bug affects the 8.5.x(LTS) versions.component/backup-restoreComponent: backup, import, external_storageseverity/majortype/bugThe issue is confirmed as a bug.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions