Skip to content

*: update raft-engine to optimize fetch_entries_to.#18617

Merged
ti-chi-bot[bot] merged 4 commits intotikv:masterfrom
LykxSassinator:update_raft_engine
Jul 6, 2025
Merged

*: update raft-engine to optimize fetch_entries_to.#18617
ti-chi-bot[bot] merged 4 commits intotikv:masterfrom
LykxSassinator:update_raft_engine

Conversation

@LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Jul 2, 2025

What is changed and how it works?

Issue Number: Close #18605

More details can be reviewed in tikv/raft-engine#382.

What's Changed:

Optimizes `fetch_entries_to` in Raft-Engine to reduce contention and improve performance under mixed workloads.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Optimizes `fetch_entries_to` in Raft-Engine to reduce contention and improve performance under mixed workloads.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 2, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 2, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 2, 2025
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 2, 2025
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 6, 2025
@LykxSassinator LykxSassinator marked this pull request as ready for review July 6, 2025 04:27
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2025
@LykxSassinator
Copy link
Contributor Author

/check-issue-triage-complete

@LykxSassinator LykxSassinator added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Jul 6, 2025
@LykxSassinator LykxSassinator requested a review from overvenus July 6, 2025 04:30
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator LykxSassinator requested a review from glorv July 6, 2025 04:33
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 6, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 6, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-06 05:25:56.606360295 +0000 UTC m=+1804609.329539269: ☑️ agreed by glorv.
  • 2025-07-06 07:29:58.060975326 +0000 UTC m=+1812050.784154305: ☑️ agreed by overvenus.

@ti-chi-bot ti-chi-bot bot merged commit 81837d7 into tikv:master Jul 6, 2025
8 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Jul 6, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #18672.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Jul 6, 2025
close tikv#18605

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Jul 6, 2025
close tikv#18605

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18673.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Jul 6, 2025
close tikv#18605

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #18674.
But this PR has conflicts, please resolve them!

ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2025
close #18605

Optimizes `fetch_entries_to` in Raft-Engine to reduce contention and improve performance under mixed workloads.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>

Co-authored-by: lucasliang <nkcs_lykx@hotmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Jul 11, 2025
close #18605

Optimizes `fetch_entries_to` in Raft-Engine to reduce contention and improve performance under mixed workloads.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>

Co-authored-by: lucasliang <nkcs_lykx@hotmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Jul 14, 2025
close #18605

Optimizes `fetch_entries_to` in Raft-Engine to reduce contention and improve performance under mixed workloads.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>

Co-authored-by: lucasliang <nkcs_lykx@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After the recovery of a TiKV failure, other TiKV node was detected as slow stores

4 participants