Skip to content

*: update raft-engine to optimize fetch_entries_to. (#18617)#18673

Merged
ti-chi-bot[bot] merged 3 commits intotikv:release-8.1from
ti-chi-bot:cherry-pick-18617-to-release-8.1
Jul 14, 2025
Merged

*: update raft-engine to optimize fetch_entries_to. (#18617)#18673
ti-chi-bot[bot] merged 3 commits intotikv:release-8.1from
ti-chi-bot:cherry-pick-18617-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #18617

What is changed and how it works?

Issue Number: Close #18605

More details can be reviewed in tikv/raft-engine#382.

What's Changed:

Optimizes `fetch_entries_to` in Raft-Engine to reduce contention and improve performance under mixed workloads.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Optimizes `fetch_entries_to` in Raft-Engine to reduce contention and improve performance under mixed workloads.

close tikv#18605

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jul 6, 2025
@ti-chi-bot
Copy link
Member Author

@LykxSassinator This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2025
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 6, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 6, 2025
@LykxSassinator LykxSassinator requested a review from overvenus July 6, 2025 11:32
@LykxSassinator
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2025
Cargo.lock Outdated
version = "0.4.2"
source = "git+https://github.com/tikv/raft-engine.git#de1ec937529e3a88e093db0cf0d403522565fe64"
version = "0.4.1"
source = "git+https://github.com/tikv/raft-engine.git?branch=tikv-7.5#ddf3c90b8086fcc6944aaefb0d4ef119e9028dd5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bishengh@Mac Pro ~/code/raft-engine$ git merge-base de1ec937529e3a88e093db0cf0d403522565fe64 upstream/tikv-7.5
e505d631c8c6d63f7fc63d83ea6e8fb88cf970a5

bishengh@Mac Pro ~/code/raft-engine$ git log --oneline e505d631c8c6d63f7fc63d83ea6e8fb88cf970a5...de1ec937529e3a88e093db0cf0d403522565fe64 | grep -v "community membership "
de1ec93 Fix `panics` on reading entries by stale index. (#370)
e1c5dd8 CI: update CI workflows. (#372)
c1f81d4 ci: add prow OWNERS file (#361)
cf5d1b9 Update strum requirement from 0.25.0 to 0.26.2 (#356)
cd1533d engine: supply the metric of the compression ratio on write. (#358)
084c5ca *: bump 0.4.2 (#357)

bishengh@Mac Pro ~/code/raft-engine$ git log --oneline e505d631c8c6d63f7fc63d83ea6e8fb88cf970a5...upstream/tikv-7.5 | grep -v "community membership " 
ddf3c90 [cp-7.5] Optimize `fetch_entries_to` function to avoid stucking `write` too long. (#382) (#384)
8cb23f1 [Cherry-pick] CP #370 & #372 to tikv-7.5  (#376)

It looks like commit tikv/raft-engine#358 will be lost if we switch to the 7.5 branch. @LykxSassinator

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for reminding. I've updated by creating a new branch tikv-8.1 and cherry-picked relevant PRs into it.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 11, 2025
@LykxSassinator LykxSassinator added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2025
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2025
@LykxSassinator LykxSassinator removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2025
@LykxSassinator LykxSassinator requested a review from hbisheng July 12, 2025 09:42
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbisheng, LykxSassinator

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 14, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 14, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-06 11:31:58.706797401 +0000 UTC m=+1826571.429976368: ☑️ agreed by LykxSassinator.
  • 2025-07-14 02:23:50.665009781 +0000 UTC m=+2484883.388188763: ☑️ agreed by hbisheng.

@ti-chi-bot ti-chi-bot bot merged commit 767b7d8 into tikv:release-8.1 Jul 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants