Skip to content

br: clean up failed downloaded files and fix metrics#18614

Merged
ti-chi-bot[bot] merged 4 commits intotikv:masterfrom
Tristan1900:fix-metrcis-and-cleanup-files
Oct 23, 2025
Merged

br: clean up failed downloaded files and fix metrics#18614
ti-chi-bot[bot] merged 4 commits intotikv:masterfrom
Tristan1900:fix-metrcis-and-cleanup-files

Conversation

@Tristan1900
Copy link
Contributor

@Tristan1900 Tristan1900 commented Jul 1, 2025 •
edited by v01dstar
Loading

What is changed and how it works?

Issue Number: Close #18604 #18839

What's Changed:

In test we noticed if download sst failed half way due to some reason, the files are not deleted and thus occupying spaces. We should clean them up.
Fix broken br metrics and add one more for download failures

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

In test we noticed if download sst failed half way due to some reason, the files are not deleted and thus occupying spaces. We should clean them up.
Fix broken metrics and add one more for download failures
run ./scripts/gen-tikv-details-dashboard seems people forgot to run it in a while

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. contribution This PR is from a community contributor. labels Jul 1, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 1, 2025

Hi @Tristan1900. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-linked-issue size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 1, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 4, 2025
@Tristan1900
br: clean up failed downloaded files and fix metrics
3707202 
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@Tristan1900
fix and generate json
f096412 
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@Tristan1900
make it simpler and rebase
2de6b15 
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@Tristan1900 Tristan1900 force-pushed the fix-metrcis-and-cleanup-files branch from ca37098 to 2de6b15 Compare September 22, 2025 20:31
@Tristan1900
revert
e9164d7 
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 22, 2025
@Tristan1900 Tristan1900 requested a review from Leavrth September 23, 2025 13:13
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2025

@Leavrth: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 23, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-04 08:12:34.857120081 +0000 UTC m=+1641807.580299058: ☑️ agreed by Leavrth.
  • 2025-10-23 09:14:43.865317783 +0000 UTC m=+949589.942570343: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit b75b404 into tikv:master Oct 23, 2025
9 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Oct 23, 2025
@YuJuncen YuJuncen mentioned this pull request Dec 9, 2025
Closed
@YuJuncen YuJuncen added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 9, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Dec 9, 2025
@Tristan1900 @ti-chi-bot
br: clean up failed downloaded files and fix metrics (tikv#18614)
1a9387f 
close tikv#18604

In test we noticed if download sst failed half way due to some reason, the files are not deleted and thus occupying spaces. We should clean them up.
Fix broken br metrics and add one more for download failures

Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 9, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #19192.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 9, 2025
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 10, 2025
@ti-chi-bot @Tristan1900
br: clean up failed downloaded files and fix metrics (#18614) (#19192)
aad7bee 
close #18604

In test we noticed if download sst failed half way due to some reason, the files are not deleted and thus occupying spaces. We should clean them up.
Fix broken br metrics and add one more for download failures

Signed-off-by: Wenqi Mou <wenqimou@gmail.com>

Co-authored-by: Wenqi Mou <wenqimou@gmail.com>
@Leavrth Leavrth mentioned this pull request Dec 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

+1 more reviewer

@Leavrth Leavrth Leavrth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

br: metrics - sst download failed should not counted as success

4 participants

@Tristan1900 @ti-chi-bot @YuJuncen @Leavrth