Skip to content

br: clean up failed downloaded files and fix metrics (#18614)#19192

Merged
ti-chi-bot[bot] merged 1 commit intotikv:release-8.5from
ti-chi-bot:cherry-pick-18614-to-release-8.5
Dec 10, 2025
Merged

br: clean up failed downloaded files and fix metrics (#18614)#19192
ti-chi-bot[bot] merged 1 commit intotikv:release-8.5from
ti-chi-bot:cherry-pick-18614-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 9, 2025 •
edited by v01dstar
Loading

This is an automated cherry-pick of #18614

What is changed and how it works?

Issue Number: Close #18604 #18839

What's Changed:

In test we noticed if download sst failed half way due to some reason, the files are not deleted and thus occupying spaces. We should clean them up.
Fix broken br metrics and add one more for download failures

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

In test we noticed if download sst failed half way due to some reason, the files are not deleted and thus occupying spaces. We should clean them up.
Fix broken metrics and add one more for download failures
run ./scripts/gen-tikv-details-dashboard seems people forgot to run it in a while

@Tristan1900 @ti-chi-bot
br: clean up failed downloaded files and fix metrics (tikv#18614)
1a9387f 
close tikv#18604

In test we noticed if download sst failed half way due to some reason, the files are not deleted and thus occupying spaces. We should clean them up.
Fix broken br metrics and add one more for download failures

Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 9, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 9, 2025
Merged
9 tasks
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 9, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 10, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-09 07:01:57.862128914 +0000 UTC m=+938062.675906486: ☑️ agreed by YuJuncen.
  • 2025-12-10 03:04:46.502331663 +0000 UTC m=+1010231.316109234: ☑️ agreed by 3pointer.

@ti-chi-bot ti-chi-bot bot merged commit aad7bee into tikv:release-8.5 Dec 10, 2025
5 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-18614-to-release-8.5 branch December 10, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

+1 more reviewer

@3pointer 3pointer 3pointer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @3pointer @YuJuncen @Tristan1900