Skip to content

cherry-pick: br: sst_importer: spawn switch mode (#18542)#18552

Merged
ti-chi-bot[bot] merged 1 commit intotikv:release-8.5-20250122-v8.5.0from
Tristan1900:release-8.5-20250122-v8.5.0-fork2
Jun 17, 2025
Merged

cherry-pick: br: sst_importer: spawn switch mode (#18542)#18552
ti-chi-bot[bot] merged 1 commit intotikv:release-8.5-20250122-v8.5.0from
Tristan1900:release-8.5-20250122-v8.5.0-fork2

Conversation

@Tristan1900
Copy link
Contributor

@Tristan1900 Tristan1900 commented Jun 16, 2025 •
edited
Loading

close #18541

Run RPC function switch_mode on the blocking acceptable thread.

What is changed and how it works?

Issue Number: Close #xxx

What's Changed:

Run RPC function switch_mode on the blocking acceptable thread.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Run RPC function switch_mode on the blocking acceptable thread.

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 16, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 16, 2025

Hi @Tristan1900. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 16, 2025
@Tristan1900
Copy link
Contributor Author

Tristan1900 commented Jun 16, 2025

/ok-to-test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 16, 2025

@Tristan1900: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 16, 2025
@Leavrth @Tristan1900
sst_importer: spawn switch mode (tikv#18542)
21b20db 
close tikv#18541

Run RPC function switch_mode on the blocking acceptable thread.

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@Tristan1900 Tristan1900 force-pushed the release-8.5-20250122-v8.5.0-fork2 branch from 2a51c25 to 21b20db Compare June 16, 2025 16:31
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 16, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 17, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-16 21:12:19.099726029 +0000 UTC m=+133391.822905004: ☑️ agreed by 3pointer.
  • 2025-06-17 02:54:52.390233557 +0000 UTC m=+153945.113412537: ☑️ agreed by overvenus.

@Leavrth
Copy link
Contributor

Leavrth commented Jun 17, 2025

/retest

@Leavrth
Copy link
Contributor

Leavrth commented Jun 17, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 17, 2025
@Leavrth
Copy link
Contributor

Leavrth commented Jun 17, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit a7d1728 into tikv:release-8.5-20250122-v8.5.0 Jun 17, 2025
4 checks passed
RidRisR pushed a commit to RidRisR/tikv that referenced this pull request Oct 9, 2025
@Tristan1900 @Leavrth @RidRisR
cherry-pick: br: sst_importer: spawn switch mode (tikv#18542) (tikv#1…
33e2789 
…8552)

close tikv#18541

Run RPC function switch_mode on the blocking acceptable thread.

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>

Co-authored-by: Jianjun Liao <36503113+Leavrth@users.noreply.github.com>
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

+1 more reviewer

@3pointer 3pointer 3pointer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Tristan1900 @Leavrth @overvenus @3pointer