Skip to content

sst_importer: spawn switch mode#18542

Merged
ti-chi-bot[bot] merged 3 commits intotikv:masterfrom
Leavrth:spawn_switch_mode
Jun 16, 2025
Merged

sst_importer: spawn switch mode#18542
ti-chi-bot[bot] merged 3 commits intotikv:masterfrom
Leavrth:spawn_switch_mode

Conversation

@Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Jun 12, 2025

What is changed and how it works?

Issue Number: Close #18541

What's Changed:

Run RPC function switch_mode on the blocking acceptable thread.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 12, 2025
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 12, 2025
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 16, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 16, 2025

@YuJuncen: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 16, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 16, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 16, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-16 08:47:43.904875354 +0000 UTC m=+88716.628054332: ☑️ agreed by YuJuncen.
  • 2025-06-16 08:52:42.369189268 +0000 UTC m=+89015.092368250: ☑️ agreed by 3pointer.

@ti-chi-bot ti-chi-bot bot merged commit 452692b into tikv:master Jun 16, 2025
8 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Jun 16, 2025
Tristan1900 pushed a commit to Tristan1900/tikv that referenced this pull request Jun 16, 2025
close tikv#18541

Run RPC function switch_mode on the blocking acceptable thread.

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Tristan1900 pushed a commit to Tristan1900/tikv that referenced this pull request Jun 16, 2025
close tikv#18541

Run RPC function switch_mode on the blocking acceptable thread.

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Jun 17, 2025
close #18541

Run RPC function switch_mode on the blocking acceptable thread.

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>

Co-authored-by: Jianjun Liao <36503113+Leavrth@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jul 1, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #18608.

ti-chi-bot bot pushed a commit that referenced this pull request Jul 8, 2025
close #18541

Run RPC function switch_mode on the blocking acceptable thread.

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>

Co-authored-by: Jianjun Liao <jianjun.liao@outlook.com>
RidRisR pushed a commit to RidRisR/tikv that referenced this pull request Oct 9, 2025
…8552)

close tikv#18541

Run RPC function switch_mode on the blocking acceptable thread.

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>

Co-authored-by: Jianjun Liao <36503113+Leavrth@users.noreply.github.com>
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

import mode takes more than 17 seconds

4 participants