Skip to content

[hotfix-to-7.5] storage: support online config for flow-control module (#17396).#18523

Merged
overvenus merged 1 commit intotikv:add-index-ingest-allow-writefrom
LykxSassinator:add-index-ingest-allow-write
Jun 8, 2025
Merged

[hotfix-to-7.5] storage: support online config for flow-control module (#17396).#18523
overvenus merged 1 commit intotikv:add-index-ingest-allow-writefrom
LykxSassinator:add-index-ingest-allow-write

Conversation

@LykxSassinator
Copy link
Contributor

This is a manual cherry-pick of #17396

What is changed and how it works?

Issue Number: Close #17395

What's Changed:

support online config for flow-control module

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Support online config change for flow-control related configs

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 8, 2025
@LykxSassinator LykxSassinator requested a review from overvenus June 8, 2025 05:50
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: overvenus
Once this PR has been reviewed and has the lgtm label, please assign zhangjinpeng87 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 8, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 8, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-08 06:02:34.900257315 +0000 UTC m=+162133.128572571: ☑️ agreed by overvenus.

@overvenus overvenus merged commit 936c043 into tikv:add-index-ingest-allow-write Jun 8, 2025
2 of 3 checks passed
@LykxSassinator LykxSassinator deleted the add-index-ingest-allow-write branch June 9, 2025 02:01
ti-chi-bot bot pushed a commit that referenced this pull request Jun 10, 2025
 

Rollup of following sst ingestion optimizations

* raftstore: directly write kvs rather than ingestion when merging small regions. (#17408) (#18518)
* raftstore: remove stale ranges by DeleteByKeys rather than ingesting. (#18040) (#18519)
* raftstore: support rocksdb writes during ingestion #18096 (#18520)
* storage: support online config for flow-control module (#17396). (#18523)
* sst_importer: allow write during ingesting sst (#18514) (#18522)

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>

Co-authored-by: lucasliang <nkcs_lykx@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants