Skip to content

sst_importer: allow write during ingesting sst#18522

Merged
overvenus merged 1 commit intotikv:add-index-ingest-allow-writefrom
overvenus:cp-add-index-ingest-allow-write
Jun 9, 2025
Merged

sst_importer: allow write during ingesting sst#18522
overvenus merged 1 commit intotikv:add-index-ingest-allow-writefrom
overvenus:cp-add-index-ingest-allow-write

Conversation

@overvenus
Copy link
Member

Cherry-picked from #18514

What is changed and how it works?

Issue Number: ref #18081

What's Changed:


Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

Optimize tail request latency during TiDB add index

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 7, 2025
@overvenus overvenus marked this pull request as ready for review June 9, 2025 09:19
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2025
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 9, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Connor1996, LykxSassinator

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Connor1996,LykxSassinator]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 9, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-09 09:20:32.659044325 +0000 UTC m=+260410.887359583: ☑️ agreed by Connor1996.
  • 2025-06-09 09:20:51.750045734 +0000 UTC m=+260429.978360998: ☑️ agreed by LykxSassinator.

ref tikv#18081

Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus force-pushed the cp-add-index-ingest-allow-write branch from 3a0c715 to bfefccf Compare June 9, 2025 09:21
@overvenus overvenus merged commit 571a8a4 into tikv:add-index-ingest-allow-write Jun 9, 2025
2 of 3 checks passed
ti-chi-bot bot pushed a commit that referenced this pull request Jun 10, 2025
 

Rollup of following sst ingestion optimizations

* raftstore: directly write kvs rather than ingestion when merging small regions. (#17408) (#18518)
* raftstore: remove stale ranges by DeleteByKeys rather than ingesting. (#18040) (#18519)
* raftstore: support rocksdb writes during ingestion #18096 (#18520)
* storage: support online config for flow-control module (#17396). (#18523)
* sst_importer: allow write during ingesting sst (#18514) (#18522)

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>

Co-authored-by: lucasliang <nkcs_lykx@hotmail.com>
overvenus added a commit to ti-chi-bot/tikv that referenced this pull request Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants