Skip to content

Titan: Fix turning off compatibility issue#18495

Merged
ti-chi-bot[bot] merged 4 commits intotikv:masterfrom
v01dstar:titan-comments
Jun 13, 2025
Merged

Titan: Fix turning off compatibility issue#18495
ti-chi-bot[bot] merged 4 commits intotikv:masterfrom
v01dstar:titan-comments

Conversation

@v01dstar
Copy link
Member

@v01dstar v01dstar commented Jun 1, 2025 •
edited
Loading

What is changed and how it works?

Issue Number: Close #18434

What's Changed:

Fixing Titan blob indices causing snapshot apply failures after Titan is turned off bug.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fixing Titan blob indices causing snapshot apply failures after Titan is turned off bug.

@v01dstar
Add failpoint, add Titan fix
a705f5d 
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 1, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed do-not-merge/needs-linked-issue dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 1, 2025
@v01dstar
Use master branch
7ed1384 
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
@v01dstar v01dstar marked this pull request as ready for review June 9, 2025 20:57
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2025
hbisheng
hbisheng reviewed Jun 12, 2025
View reviewed changes
@v01dstar
Fix comment
381d070 
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
overvenus
overvenus approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 12, 2025
@v01dstar
Add read and write at the end
a275590 
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
@v01dstar
Copy link
Member Author

v01dstar commented Jun 12, 2025

/retest-required

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbisheng, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 13, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-12 06:53:59.03017848 +0000 UTC m=+510817.258493740: ☑️ agreed by overvenus.
  • 2025-06-13 03:01:10.846908894 +0000 UTC m=+583249.075224155: ☑️ agreed by hbisheng.

@ti-chi-bot ti-chi-bot bot merged commit e11725c into tikv:master Jun 13, 2025
8 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Jun 13, 2025
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jun 27, 2025
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 27, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #18599.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Jun 27, 2025
@v01dstar @ti-chi-bot
This is an automated cherry-pick of tikv#18495
785dbad 
close tikv#18434

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 27, 2025
Merged
9 tasks
v01dstar added a commit to ti-chi-bot/tikv that referenced this pull request Jul 1, 2025
@v01dstar
This is an automated cherry-pick of tikv#18495
36abedb 
close tikv#18434

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
v01dstar added a commit to ti-chi-bot/tikv that referenced this pull request Jul 1, 2025
@v01dstar
This is a cherry-pick of tikv#18495
911b89f 
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request Jul 3, 2025
@ti-chi-bot @v01dstar
Titan: Fix turning off compatibility issue (#18495) (#18599)
69c15d4 
close #18434

Fixing Titan blob indices causing snapshot apply failures after Titan is turned off bug.

Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>

Co-authored-by: Yang Zhang <yang.zhang@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

@LykxSassinator LykxSassinator Awaiting requested review from LykxSassinator

+1 more reviewer

@hbisheng hbisheng hbisheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

TiKV crash when applying snapshots after turning off Titan

4 participants

@v01dstar @ti-chi-bot @overvenus @hbisheng