Skip to content

Titan: Fix turning off compatibility issue (#18495)#18599

Merged
ti-chi-bot[bot] merged 1 commit intotikv:release-8.5from
ti-chi-bot:cherry-pick-18495-to-release-8.5
Jul 3, 2025
Merged

Titan: Fix turning off compatibility issue (#18495)#18599
ti-chi-bot[bot] merged 1 commit intotikv:release-8.5from
ti-chi-bot:cherry-pick-18495-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jun 27, 2025

This is an automated cherry-pick of #18495

What is changed and how it works?

Issue Number: Close #18434

What's Changed:

Fixing Titan blob indices causing snapshot apply failures after Titan is turned off bug.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fixing Titan blob indices causing snapshot apply failures after Titan is turned off bug.

@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jun 27, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 27, 2025
Merged
9 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jun 27, 2025

@v01dstar This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 27, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 28, 2025
@v01dstar v01dstar force-pushed the cherry-pick-18495-to-release-8.5 branch from 785dbad to 36abedb Compare July 1, 2025 01:16
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 1, 2025
@v01dstar
This is a cherry-pick of tikv#18495
911b89f 
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
@v01dstar v01dstar force-pushed the cherry-pick-18495-to-release-8.5 branch from ae56365 to 911b89f Compare July 1, 2025 02:40
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LykxSassinator, v01dstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 2, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 2, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-28 06:15:51.517390989 +0000 UTC m=+1116404.240569971: ☑️ agreed by v01dstar.
  • 2025-07-02 09:22:05.843101243 +0000 UTC m=+1473178.566280222: ☑️ agreed by LykxSassinator.

@v01dstar
Copy link
Member

v01dstar commented Jul 3, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2025
@ti-chi-bot ti-chi-bot bot merged commit 69c15d4 into tikv:release-8.5 Jul 3, 2025
4 checks passed
@v01dstar v01dstar deleted the cherry-pick-18495-to-release-8.5 branch July 4, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v01dstar v01dstar v01dstar approved these changes

@LykxSassinator LykxSassinator LykxSassinator approved these changes

Assignees

@v01dstar v01dstar

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @v01dstar @LykxSassinator