Skip to content

backup: move verbose errors to warn level#18494

Merged
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
YuJuncen:slient-verbose-error
Jun 6, 2025
Merged

backup: move verbose errors to warn level#18494
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
YuJuncen:slient-verbose-error

Conversation

@YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented May 30, 2025

What is changed and how it works?

Issue Number: Close #18493

What's Changed:

Some of non-fatal error level logs during backing up are now warn level.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Some of non-fatal error level logs during backing up are now warn level.

Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 30, 2025
}),
);
if let Err(e) = res {
// TODO: handle error.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed because BR client somehow handles this by the range tree.

Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 6, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 6, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 6, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-06 07:30:14.770578615 +0000 UTC m=+599700.972923877: ☑️ agreed by 3pointer.
  • 2025-06-06 07:31:57.684725557 +0000 UTC m=+599803.887070822: ☑️ agreed by Leavrth.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, iosmanthus, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 6, 2025
@ti-chi-bot ti-chi-bot bot merged commit 72760df into tikv:master Jun 6, 2025
8 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Jun 6, 2025
@YuJuncen YuJuncen added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jul 28, 2025
@YuJuncen
Copy link
Contributor Author

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #18752.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Jul 28, 2025
close tikv#18493

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@YuJuncen YuJuncen added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Aug 25, 2025
@YuJuncen
Copy link
Contributor Author

/run-cherry-picker

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Aug 25, 2025
close tikv#18493

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #18877.
But this PR has conflicts, please resolve them!

ti-chi-bot bot pushed a commit that referenced this pull request Sep 1, 2025
close #18493

Some of non-fatal error level logs during backing up are now warn level.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: Juncen Yu <yujuncen@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

br: reduce non-fatal error logs' level

5 participants