Skip to content

backup: move verbose errors to warn level (#18494)#18752

Merged
ti-chi-bot[bot] merged 3 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18494-to-release-8.5
Sep 1, 2025
Merged

backup: move verbose errors to warn level (#18494)#18752
ti-chi-bot[bot] merged 3 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18494-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jul 28, 2025

This is an automated cherry-pick of #18494

What is changed and how it works?

Issue Number: Close #18493

What's Changed:

Some of non-fatal error level logs during backing up are now warn level.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Some of non-fatal error level logs during backing up are now warn level.

@YuJuncen @ti-chi-bot
This is an automated cherry-pick of tikv#18494
03b1460 
close tikv#18493

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jul 28, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 28, 2025
Merged
9 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 28, 2025

@YuJuncen This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2025

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@YuJuncen
resolve conflict
b8280b2 
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 28, 2025
@YuJuncen
make switch mode errors to warn
69b7eba 
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 28, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-28 06:33:47.243609581 +0000 UTC m=+248835.710172367: ☑️ agreed by YuJuncen.
  • 2025-08-28 02:27:52.156943184 +0000 UTC m=+407164.034774138: ☑️ agreed by Leavrth.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 28, 2025
@YuJuncen
Copy link
Contributor

YuJuncen commented Sep 1, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2025
@ti-chi-bot ti-chi-bot bot merged commit c68a869 into tikv:release-8.5 Sep 1, 2025
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-18494-to-release-8.5 branch September 1, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

+2 more reviewers

@3pointer 3pointer 3pointer approved these changes

@Leavrth Leavrth Leavrth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@YuJuncen YuJuncen

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @YuJuncen @3pointer @Leavrth