Skip to content

titan: Fix titan is disabled unexpectedly after new instance restart#18319

Merged
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
Connor1996:fix-titan-default
Mar 28, 2025
Merged

titan: Fix titan is disabled unexpectedly after new instance restart#18319
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
Connor1996:fix-titan-default

Conversation

@Connor1996
Copy link
Member

@Connor1996 Connor1996 commented Mar 18, 2025

What is changed and how it works?

Issue Number: Close #18318

What's Changed:

Fix titan is disabled unexpectedly after new instance restart

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fix titan is disabled unexpectedly after new instance restart

@Connor1996
fix titan is disabled unexpectedly after new instance restart
e44617b 
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 18, 2025
glorv
glorv approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 18, 2025
@glorv
Copy link
Contributor

glorv commented Mar 18, 2025

/check-issue-triage-complete

@glorv glorv requested a review from v01dstar March 18, 2025 16:16
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 19, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 19, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-18 16:14:00.013920657 +0000 UTC m=+372133.698156739: ☑️ agreed by glorv.
  • 2025-03-19 07:36:47.582258777 +0000 UTC m=+427501.266494874: ☑️ agreed by LykxSassinator.

@Connor1996
Copy link
Member Author

Connor1996 commented Mar 19, 2025

/approve

@glorv
Copy link
Contributor

glorv commented Mar 19, 2025

@zhangjinpeng87 @cfzjywxk PTAL as it involves config change.

zhangjinpeng87
zhangjinpeng87 approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the approved label Mar 28, 2025
@zhangjinpeng87
Copy link
Member

zhangjinpeng87 commented Mar 28, 2025

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 28, 2025

@zhangjinpeng87: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: Proposal: Strengthen configuration change approval.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zhangjinpeng87
Copy link
Member

zhangjinpeng87 commented Mar 28, 2025

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Connor1996, glorv, LykxSassinator, zhangjinpeng87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 678f6ab into tikv:master Mar 28, 2025
8 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Mar 28, 2025
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Apr 14, 2025
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 14, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #18388.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 14, 2025
Merged
9 tasks
@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Apr 14, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Apr 17, 2025
@ti-chi-bot @Connor1996
titan: Fix titan is disabled unexpectedly after new instance restart (#…
3de3ac8 
…18319) (#18388)

close #18318

Fix titan is disabled unexpectedly after new instance restart

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

Co-authored-by: Connor1996 <zbk602423539@gmail.com>
@canhld94 canhld94 mentioned this pull request Mar 6, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glorv glorv glorv approved these changes

@LykxSassinator LykxSassinator LykxSassinator approved these changes

@zhangjinpeng87 zhangjinpeng87 zhangjinpeng87 approved these changes

@v01dstar v01dstar Awaiting requested review from v01dstar

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

Titan Disabled After tikv Restart

5 participants

@Connor1996 @glorv @zhangjinpeng87 @ti-chi-bot @LykxSassinator