Skip to content

raftstore: record IO duration#18269

Merged
ti-chi-bot[bot] merged 5 commits intotikv:masterfrom
overvenus:p99/metrics
Mar 7, 2025
Merged

raftstore: record IO duration#18269
ti-chi-bot[bot] merged 5 commits intotikv:masterfrom
overvenus:p99/metrics

Conversation

@overvenus
Copy link
Member

@overvenus overvenus commented Mar 4, 2025

What is changed and how it works?

Issue Number: close #18276 ref #18256

What's Changed:

Record and export raftstore IO duration to TiKV dashboard.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Run sysbench insert_only workload, enable shuffle region and inject IO delay.

Panels Panels
image image
image image

Release note

None

Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Mar 4, 2025
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 5, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 7, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, LykxSassinator

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LykxSassinator,glorv]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 7, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-05 07:18:54.654018426 +0000 UTC m=+426047.782938169: ☑️ agreed by LykxSassinator.
  • 2025-03-07 06:48:13.331205695 +0000 UTC m=+597006.460125438: ☑️ agreed by glorv.

@ti-chi-bot ti-chi-bot bot merged commit c650e8a into tikv:master Mar 7, 2025
8 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Mar 7, 2025
overvenus added a commit to overvenus/tikv that referenced this pull request Jun 23, 2025
ref tikv#18256, close tikv#18276

Record and export raftstore IO duration to TiKV dashboard.

Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Jul 3, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Jul 3, 2025
ref tikv#18256, close tikv#18276

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Jul 3, 2025
ref tikv#18256, close tikv#18276

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #18629.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Jul 3, 2025
ref tikv#18256, close tikv#18276

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #18630.
But this PR has conflicts, please resolve them!

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18631.
But this PR has conflicts, please resolve them!

overvenus added a commit to ti-chi-bot/tikv that referenced this pull request Jul 8, 2025
ref tikv#18256, close tikv#18276

Record and export raftstore IO duration to TiKV dashboard.

Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus added a commit to ti-chi-bot/tikv that referenced this pull request Jul 8, 2025
ref tikv#18256, close tikv#18276

Record and export raftstore IO duration to TiKV dashboard.

Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus added a commit to ti-chi-bot/tikv that referenced this pull request Jul 8, 2025
ref tikv#18256, close tikv#18276

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Neil Shen <overvenus@gmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2025
ref #18256, close #18276

Record and export raftstore IO duration to TiKV dashboard.

Signed-off-by: Neil Shen <overvenus@gmail.com>

Co-authored-by: Neil Shen <overvenus@gmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2025
ref #18256, close #18276

Record and export raftstore IO duration to TiKV dashboard.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Neil Shen <overvenus@gmail.com>

Co-authored-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export raftstore IO duration to TiKV dashboard

4 participants