Skip to content

raftstore: record IO duration (#18269)#18631

Open
ti-chi-bot wants to merge 1 commit intotikv:release-8.1from
ti-chi-bot:cherry-pick-18269-to-release-8.1
Open

raftstore: record IO duration (#18269)#18631
ti-chi-bot wants to merge 1 commit intotikv:release-8.1from
ti-chi-bot:cherry-pick-18269-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jul 3, 2025

This is an automated cherry-pick of #18269

What is changed and how it works?

Issue Number: close #18276 ref #18256

What's Changed:

Record and export raftstore IO duration to TiKV dashboard.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Run sysbench insert_only workload, enable shuffle region and inject IO delay.

Panels Panels
image image
image image

Release note

None

@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jul 3, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 3, 2025
Merged
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 3, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 3, 2025

@overvenus This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@overvenus
raftstore: record IO duration (tikv#18269)
919ccb4 
ref tikv#18256, close tikv#18276

Record and export raftstore IO duration to TiKV dashboard.

Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus force-pushed the cherry-pick-18269-to-release-8.1 branch from 290a085 to 919ccb4 Compare July 8, 2025 06:51
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 8, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 8, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LykxSassinator, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LykxSassinator,overvenus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 8, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-08 06:52:40.597903672 +0000 UTC m=+1982613.321082653: ☑️ agreed by overvenus.
  • 2025-07-08 07:13:17.280329038 +0000 UTC m=+1983850.003508020: ☑️ agreed by LykxSassinator.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 16, 2025

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-check-deps 919ccb4 link true /test pull-check-deps

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

@LykxSassinator LykxSassinator LykxSassinator approved these changes

Assignees

@overvenus overvenus

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/cherry-pick-not-approved do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @overvenus @LykxSassinator