Skip to content

cargo-deny: ignore RUSTSEC-2025-0004 check.#18181

Merged
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
LykxSassinator:fix_18179_deny
Feb 5, 2025
Merged

cargo-deny: ignore RUSTSEC-2025-0004 check.#18181
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
LykxSassinator:fix_18179_deny

Conversation

@LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Feb 5, 2025 •
edited
Loading

What is changed and how it works?

Issue Number: Close #18179

What's Changed:

Ignore the deny "RUSTSEC-2025-0004", as it will introduce recursive upgrading to
OpenSSL to v3.x from v1.x, causing performance regressions.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None.

@LykxSassinator
cargo-deny: ignore RUSTSEC-2025-0004 check.
ddaa844 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2025
overvenus
overvenus reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add openssl::ssl::select_next_proto to disallowed-methods in clippy.toml.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Feb 5, 2025

/test ?

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2025

@wuhuizuo: The following commands are available to trigger required jobs:

/test pull-unit-test

The following commands are available to trigger optional jobs:

/debug pull-integration-test

/test pull-clippy-linux-arm64

Use /test all to run the following jobs that were automatically triggered:

tikv/tikv/pull_unit_test
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Feb 5, 2025

/test pull-clippy-linux-arm64

@LykxSassinator
Address comments.
1504463 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 5, 2025
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Feb 5, 2025

/test pull-clippy-linux-arm64

@LykxSassinator
Copy link
Contributor Author

LykxSassinator commented Feb 5, 2025

/check-triage-completed

@LykxSassinator
Copy link
Contributor Author

LykxSassinator commented Feb 5, 2025

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 5, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbisheng, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-05 07:26:56.538934518 +0000 UTC m=+256688.071346516: ☑️ agreed by overvenus.
  • 2025-02-05 07:34:13.476900118 +0000 UTC m=+257125.009312116: ☑️ agreed by hbisheng.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2025

@LykxSassinator: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-clippy-linux-arm64 1504463 link false /test pull-clippy-linux-arm64

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 25e1c88 into tikv:master Feb 5, 2025
8 of 9 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Feb 5, 2025
@LykxSassinator LykxSassinator added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Feb 6, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Feb 6, 2025
@LykxSassinator @ti-chi-bot
This is an automated cherry-pick of tikv#18181
4267e39 
close tikv#18179

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 6, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #18188.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Feb 6, 2025
@LykxSassinator @ti-chi-bot
This is an automated cherry-pick of tikv#18181
b71780d 
close tikv#18179

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 6, 2025
Merged
9 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 6, 2025

In response to a cherrypick label: new pull request created to branch release-8.1: #18189.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 6, 2025
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Feb 6, 2025
@ti-chi-bot @LykxSassinator
cargo-deny: ignore RUSTSEC-2025-0004 check. (#18181) (#18189)
273a2e7 
close #18179

Ignore the deny "RUSTSEC-2025-0004", as it will introduce recursive upgrading to
OpenSSL to v3.x from v1.x, causing performance regressions.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>

Co-authored-by: lucasliang <nkcs_lykx@hotmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Feb 6, 2025
@ti-chi-bot @LykxSassinator
cargo-deny: ignore RUSTSEC-2025-0004 check. (#18181) (#18188)
46fd3c7 
close #18179

Ignore the deny "RUSTSEC-2025-0004", as it will introduce recursive upgrading to
OpenSSL to v3.x from v1.x, causing performance regressions.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>

Co-authored-by: lucasliang <nkcs_lykx@hotmail.com>
3pointer pushed a commit to 3pointer/tikv that referenced this pull request Apr 1, 2025
@LykxSassinator @3pointer
cargo-deny: ignore RUSTSEC-2025-0004 check. (tikv#18181)
a108d8f 
close tikv#18179

Ignore the deny "RUSTSEC-2025-0004", as it will introduce recursive upgrading to
OpenSSL to v3.x from v1.x, causing performance regressions.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

+1 more reviewer

@hbisheng hbisheng hbisheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

make clippy failed

5 participants

@LykxSassinator @wuhuizuo @ti-chi-bot @overvenus @hbisheng