Skip to content

cargo-deny: ignore RUSTSEC-2025-0004 check. (#18181)#18188

Merged
ti-chi-bot[bot] merged 2 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18181-to-release-8.5
Feb 6, 2025
Merged

cargo-deny: ignore RUSTSEC-2025-0004 check. (#18181)#18188
ti-chi-bot[bot] merged 2 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18181-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Feb 6, 2025

This is an automated cherry-pick of #18181

What is changed and how it works?

Issue Number: Close #18179

What's Changed:

Ignore the deny "RUSTSEC-2025-0004", as it will introduce recursive upgrading to
OpenSSL to v3.x from v1.x, causing performance regressions.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None.

@LykxSassinator @ti-chi-bot
This is an automated cherry-pick of tikv#18181
4267e39 
close tikv#18179

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Feb 6, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 6, 2025
Merged
9 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 6, 2025

@LykxSassinator This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@LykxSassinator
Address conflicts.
333e187 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 6, 2025
@LykxSassinator
Copy link
Contributor

LykxSassinator commented Feb 6, 2025

/unhold

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/cherry-pick-not-approved labels Feb 6, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 6, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbisheng, LykxSassinator

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 6, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-06 06:45:03.57242668 +0000 UTC m=+340575.104838677: ☑️ agreed by LykxSassinator.
  • 2025-02-06 06:48:58.900115192 +0000 UTC m=+340810.432527188: ☑️ agreed by hbisheng.

@3pointer
Copy link
Contributor

3pointer commented Feb 6, 2025

/test pull-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 46fd3c7 into tikv:release-8.5 Feb 6, 2025
4 checks passed
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 6, 2025

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test 333e187 link unknown /test pull-unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LykxSassinator LykxSassinator LykxSassinator approved these changes

+1 more reviewer

@hbisheng hbisheng hbisheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LykxSassinator LykxSassinator

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @LykxSassinator @3pointer @hbisheng