gc_worker: Do not do delete_files_in_range on lock cf which has potential risk to affect data correctness#18092
Merged
ti-chi-bot[bot] merged 3 commits intotikv:masterfrom Jan 13, 2025
Conversation
…to affect data correctness Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
zyguan
approved these changes
Jan 8, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, zyguan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Collaborator
|
@MyonKeminta Is it necessary to pick it to the release branch? |
Contributor
Author
@cfzjywxk I think it's not very necessary as the possibility it causes problem is too low. |
Member
|
In response to a cherrypick label: new pull request created to branch |
9 tasks
xzhangxian1008
pushed a commit
to xzhangxian1008/tikv
that referenced
this pull request
Feb 8, 2025
…tial risk to affect data correctness (tikv#18092) close tikv#18091 gc_worker: Do not do delete_files_in_range on lock cf which has potential risk to affect data correctness Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Signed-off-by: xzhangxian1008 <xzhangxian@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Issue Number: Close #18091
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note