Skip to content

gc_worker: Do not do delete_files_in_range on lock cf which has potential risk to affect data correctness (#18092)#18178

Closed
ti-chi-bot wants to merge 2 commits intotikv:release-6.5from
ti-chi-bot:cherry-pick-18092-to-release-6.5
Closed

gc_worker: Do not do delete_files_in_range on lock cf which has potential risk to affect data correctness (#18092)#18178
ti-chi-bot wants to merge 2 commits intotikv:release-6.5from
ti-chi-bot:cherry-pick-18092-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Feb 5, 2025

This is an automated cherry-pick of #18092

What is changed and how it works?

Issue Number: Close #18091

What's Changed:

gc_worker: Do not do delete_files_in_range on lock cf which has potential risk to affect data correctness

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@MyonKeminta @ti-chi-bot
gc_worker: Do not do delete_files_in_range on lock cf which has risk …
5cdfce7 
…to affect data correctness

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta @ti-chi-bot
fmt
b4685dd 
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Feb 5, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 5, 2025
Merged
9 tasks
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign little-wallace for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 5, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2025

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test b4685dd link true /test pull-unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hhwyt
Copy link
Contributor

hhwyt commented Feb 5, 2025

@MyonKeminta PTAL

@MyonKeminta
Copy link
Contributor

MyonKeminta commented Feb 5, 2025

I didn't mark it necessary to cherry pick to release versions. The bot did it anyway.

@MyonKeminta MyonKeminta closed this Feb 5, 2025
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Feb 5, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@MyonKeminta MyonKeminta

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @hhwyt @MyonKeminta