Skip to content

Refactor Resizable Runtime from blocking TiKV shutting down.#17784

Merged
ti-chi-bot[bot] merged 61 commits intotikv:masterfrom
RidRisR:refactor
Nov 28, 2024
Merged

Refactor Resizable Runtime from blocking TiKV shutting down.#17784
ti-chi-bot[bot] merged 61 commits intotikv:masterfrom
RidRisR:refactor

Conversation

@RidRisR
Copy link
Contributor

@RidRisR RidRisR commented Nov 7, 2024 •
edited
Loading

What is changed and how it works?

Issue Number: Close #17807 #17572

What's Changed:

A new version of resizable runtime is added, with same performance but won't block the tikv shutting down.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

A new version of resizable runtime is added, with same performance but won't block the tikv shutting down.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 7, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2024

Hi @RidRisR. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. dco-signoff: no Indicates the PR's author has not signed dco. labels Nov 7, 2024
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. dco-signoff: no Indicates the PR's author has not signed dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. dco-signoff: yes Indicates the PR's author has signed the dco. labels Nov 7, 2024
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. dco-signoff: no Indicates the PR's author has not signed dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. dco-signoff: yes Indicates the PR's author has signed the dco. labels Nov 7, 2024
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed dco-signoff: no Indicates the PR's author has not signed dco. do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 12, 2024
@RidRisR RidRisR marked this pull request as ready for review November 12, 2024 09:37
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2024
@RidRisR RidRisR changed the title Refactor runtime Refactor Resizable Runtime to avoid blocking TiKV shutting down. Nov 12, 2024
@RidRisR
larger lock
78aabdc 
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
@RidRisR
fix test
018dba2 
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
@RidRisR
make clippy
9c41430 
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
@RidRisR
lint
f580400 
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
@RidRisR
fix test
eff9611 
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
kennytm
kennytm reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

ti-chi-bot bot and others added 3 commits November 27, 2024 06:06
@ti-chi-bot
Merge branch 'master' into refactor
e35a369
@RidRisR
fix comment
8b8cf24 
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
@RidRisR
lint
f852814 
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
kennytm
kennytm reviewed Nov 27, 2024
View reviewed changes
@RidRisR
improvement
505b245 
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
@RidRisR
lint
7907e23 
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
@RidRisR
cleanup ut
edf2467 
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
kennytm
kennytm approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@RidRisR
fix comment
768b792 
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
@RidRisR
minimize lock
7a5ed54 
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
@RidRisR
add log
15aa62a 
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
kennytm
kennytm reviewed Nov 27, 2024
View reviewed changes
@RidRisR
minimize lock
05ec6a6 
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
zhangjinpeng87
zhangjinpeng87 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change of components/sst_importer/src/config.rs LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kennytm, Leavrth, YuJuncen, zhangjinpeng87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@YuJuncen
Copy link
Contributor

YuJuncen commented Nov 28, 2024

/run-cherry-picker

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 28, 2024

In response to a cherrypick label: new pull request created to branch release-8.1: #17902.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 28, 2024
Merged
9 tasks
@michaelmdeng michaelmdeng mentioned this pull request Jan 16, 2025
Merged
9 tasks
@BornChanger
Copy link
Contributor

BornChanger commented Jan 21, 2025

/label needs-cherry-pick-release-8.5

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 21, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #18149.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 21, 2025
Merged
9 tasks
@RidRisR RidRisR mentioned this pull request Jan 22, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm kennytm approved these changes

@zhangjinpeng87 zhangjinpeng87 zhangjinpeng87 approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

@glorv glorv Awaiting requested review from glorv

@Leavrth Leavrth Awaiting requested review from Leavrth

Assignees

No one assigned

Labels

approved contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

br: The ResizableRuntime make some unit test taking too long to finish

8 participants

@RidRisR @YuJuncen @kennytm @ti-chi-bot @BornChanger @glorv @zhangjinpeng87 @Leavrth