Skip to content

Refactor Resizable Runtime from blocking TiKV shutting down. (#17784)#18149

Merged
ti-chi-bot[bot] merged 5 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-17784-to-release-8.5
Jan 22, 2025
Merged

Refactor Resizable Runtime from blocking TiKV shutting down. (#17784)#18149
ti-chi-bot[bot] merged 5 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-17784-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #17784

What is changed and how it works?

Issue Number: Close #17807 #17572

What's Changed:

A new version of resizable runtime is added, with same performance but won't block the tikv shutting down.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

A new version of resizable runtime is added, with same performance but won't block the tikv shutting down.

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jan 21, 2025
@RidRisR
Copy link
Contributor

RidRisR commented Jan 21, 2025

/cherry-pick-invite

@ti-chi-bot
Copy link
Member Author

@RidRisR you're not a member of org tikv

@ti-chi-bot ti-chi-bot bot added dco-signoff: no Indicates the PR's author has not signed dco. and removed dco-signoff: yes Indicates the PR's author has signed the dco. labels Jan 21, 2025
close tikv#17807

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
@RidRisR RidRisR force-pushed the cherry-pick-17784-to-release-8.5 branch from 2f9a811 to bd169b6 Compare January 21, 2025 09:00
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. dco-signoff: no Indicates the PR's author has not signed dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. dco-signoff: yes Indicates the PR's author has signed the dco. labels Jan 21, 2025
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
@RidRisR RidRisR force-pushed the cherry-pick-17784-to-release-8.5 branch from cc3cf5b to 21c8256 Compare January 21, 2025 09:58
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. cherry-pick-approved Cherry pick PR approved by release team. and removed dco-signoff: no Indicates the PR's author has not signed dco. do-not-merge/cherry-pick-not-approved labels Jan 21, 2025
@ti-chi-bot ti-chi-bot closed this Jan 21, 2025
@YuJuncen YuJuncen reopened this Jan 22, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 22, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 22, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 22, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-22 03:04:34.84050252 +0000 UTC m=+236402.171421924: ☑️ agreed by YuJuncen.
  • 2025-01-22 04:07:32.033024001 +0000 UTC m=+240179.363943405: ☑️ agreed by 3pointer.

@BornChanger
Copy link
Contributor

@zhangjinpeng87 please review the cherry-pick pr

Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the change in components/sst_importer/src/config.rs

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen, zhangjinpeng87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 22, 2025
@ti-chi-bot ti-chi-bot bot merged commit c3e6f87 into tikv:release-8.5 Jan 22, 2025
3 checks passed
@RidRisR RidRisR deleted the cherry-pick-17784-to-release-8.5 branch May 30, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants