Skip to content

Refactor Resizable Runtime from blocking TiKV shutting down. (#17784)#17902

Merged
ti-chi-bot[bot] merged 7 commits intotikv:release-8.1from
ti-chi-bot:cherry-pick-17784-to-release-8.1
Dec 2, 2024
Merged

Refactor Resizable Runtime from blocking TiKV shutting down. (#17784)#17902
ti-chi-bot[bot] merged 7 commits intotikv:release-8.1from
ti-chi-bot:cherry-pick-17784-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #17784

What is changed and how it works?

Issue Number: Close #17807 17807

What's Changed:

A new version of resizable runtime is added, with same performance but won't block the tikv shutting down.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

A new version of resizable runtime is added, with same performance but won't block the tikv shutting down.

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Nov 28, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved dco-signoff: no Indicates the PR's author has not signed dco. and removed dco-signoff: yes Indicates the PR's author has signed the dco. labels Nov 28, 2024
ti-chi-bot and others added 4 commits November 28, 2024 17:51
Signed-off-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: hillium <yujuncen@pingcap.com>
close tikv#17807

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
@YuJuncen YuJuncen force-pushed the cherry-pick-17784-to-release-8.1 branch from dba5422 to a9b2ba0 Compare November 28, 2024 09:56
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. labels Nov 28, 2024
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 29, 2024
Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes of components/sst_importer/src/config.rs LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YuJuncen, zhangjinpeng87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 30, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-29 05:59:01.788405071 +0000 UTC m=+788929.408059574: ☑️ agreed by YuJuncen.
  • 2024-11-30 00:41:16.416710483 +0000 UTC m=+856264.036364996: ☑️ agreed by zhangjinpeng87.

@RidRisR
Copy link
Contributor

RidRisR commented Dec 2, 2024

/test pull-unit-test

1 similar comment
@RidRisR
Copy link
Contributor

RidRisR commented Dec 2, 2024

/test pull-unit-test

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 2, 2024
@ti-chi-bot ti-chi-bot bot merged commit 7b96ecf into tikv:release-8.1 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants