In-memory Engine: fix panic when destroy an uninitialized region#17771
Merged
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom Nov 5, 2024
Merged
In-memory Engine: fix panic when destroy an uninitialized region#17771ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
Conversation
Signed-off-by: Neil Shen <overvenus@gmail.com>
glorv
approved these changes
Nov 5, 2024
SpadeA-Tang
approved these changes
Nov 5, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: glorv, SpadeA-Tang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
Member
|
In response to a cherrypick label: new pull request created to branch |
overvenus
added a commit
to overvenus/tikv
that referenced
this pull request
Nov 15, 2024
…v#17771) close tikv#17767 IME observes all peer destroy events to timely evict regions. By adding a new peer, the old and uninitialized peer will be destroyed and IME must not panic in this situation. Signed-off-by: Neil Shen <overvenus@gmail.com>
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
…17747 (#17831) ref #16141, close #17767, ref #17767 In-memory engine: handle error when getting regions info (#17805) ref #16141 handle error when getting regions info Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> --- In-memory Engine: Adjust memory settings based on available memory (#17515) ref #16141 This commit adjusts the following in-memory-engine defaults: * `capacity`: Now IME uses 10% of the block cache and takes an equal amount of memory from the system. This is based on tests showing that the IME rarely fills its full capacity. * `mvcc_amplification_threshold`: Change from 100 to 10 which benefit common workloads like TPCc (50 warehouse), saving approximately 20% of unified read pool CPU usage. Also, it addresses two security issues: * Upgrade hashbrown from yanked 0.15.0 to 0.15.1 Signed-off-by: Neil Shen <overvenus@gmail.com> --- In-memory Engine: fix panic when destroy an uninitialized region (#17771) close #17767 IME observes all peer destroy events to timely evict regions. By adding a new peer, the old and uninitialized peer will be destroyed and IME must not panic in this situation. Signed-off-by: Neil Shen <overvenus@gmail.com> --- In-memory Engine: remove dead code and fix typos (#17763) ref #16141 Signed-off-by: Neil Shen <overvenus@gmail.com> --- In-memory engine: use stop-load-threshold for loading new regions (#17747) ref #16141 use stop-load-threshold for loading new regions Signed-off-by: SpadeA-Tang <tangchenjie1210@gmail.com> Signed-off-by: Neil Shen <overvenus@gmail.com> Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> Co-authored-by: Spade A <71589810+SpadeA-Tang@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Issue Number: Close #17767
What's Changed:
Related changes
Check List
Tests
Release note