Skip to content

In-memory Engine: fix panic when destroy an uninitialized region (#17771)#17832

Closed
ti-chi-bot wants to merge 1 commit intotikv:release-8.5from
ti-chi-bot:cherry-pick-17771-to-release-8.5
Closed

In-memory Engine: fix panic when destroy an uninitialized region (#17771)#17832
ti-chi-bot wants to merge 1 commit intotikv:release-8.5from
ti-chi-bot:cherry-pick-17771-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 15, 2024

This is an automated cherry-pick of #17771

What is changed and how it works?

Issue Number: Close #17767

What's Changed:

IME observes all peer destroy events to timely evict regions. By adding
a new peer, the old and uninitialized peer will be destroyed and IME
must not panic in this situation.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Release note

None

@overvenus @ti-chi-bot
In-memory Engine: fix panic when destroy an uninitialized region
67dfd2d 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 15, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 15, 2024
Merged
@ti-chi-bot ti-chi-bot bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 15, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nrc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@overvenus overvenus closed this Nov 15, 2024
@overvenus
Copy link
Member

overvenus commented Nov 15, 2024

Closed, included in #17831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@overvenus overvenus

Labels

cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ti-chi-bot @overvenus