Skip to content

profiling: Fix cpu profiling flag may not reset when meeting errors#17235

Merged
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
Connor1996:fix-drop
Jul 4, 2024
Merged

profiling: Fix cpu profiling flag may not reset when meeting errors#17235
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
Connor1996:fix-drop

Conversation

@Connor1996
Copy link
Member

@Connor1996 Connor1996 commented Jul 4, 2024

What is changed and how it works?

Issue Number: Close #17234

What's Changed:

Fix cpu profiling flag may not reset when meeting errors

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fix the issue that CPU Profiling doesn't work reporting `Already in CPU Profiling`

@Connor1996
fix cpu profiling may not reset when meeting errors
b99e6ea 
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 4, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2024

@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Connor1996
fix build
8125052 
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 4, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 4, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-04 07:08:48.351331112 +0000 UTC m=+1481054.836819944: ☑️ agreed by glorv.
  • 2024-07-04 08:41:41.850462095 +0000 UTC m=+1486628.335950923: ☑️ agreed by LykxSassinator.

@Connor1996
Copy link
Member Author

Connor1996 commented Jul 4, 2024

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2024

@Connor1996: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: Proposal: Strengthen configuration change approval.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Connor1996
Copy link
Member Author

Connor1996 commented Jul 4, 2024

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Connor1996, glorv, LykxSassinator, mornyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Connor1996,LykxSassinator,glorv]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@glorv
Copy link
Contributor

glorv commented Jul 4, 2024

/test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2024

@glorv: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-unit-test

Use /test all to run all jobs.

Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@glorv
Copy link
Contributor

glorv commented Jul 4, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 2a05e51 into tikv:master Jul 4, 2024
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Jul 4, 2024
@overvenus overvenus added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Nov 14, 2024
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 14, 2024

In response to a cherrypick label: new pull request created to branch release-8.1: #17824.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 14, 2024
Open
9 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 14, 2024

In response to a cherrypick label: new pull request created to branch release-7.5: #17825.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Nov 14, 2024
@Connor1996 @ti-chi-bot
This is an automated cherry-pick of tikv#17235
7c709f0 
close tikv#17234

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 14, 2024
Merged
9 tasks
ti-chi-bot bot added a commit that referenced this pull request Dec 13, 2024
@ti-chi-bot @Connor1996
@hbisheng @ti-chi-bot
profiling: Fix cpu profiling flag may not reset when meeting errors (#…
ad7e997 
…17235) (#17825)

close #17234

Fix cpu profiling flag may not reset when meeting errors

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Bisheng Huang <hbisheng@gmail.com>

Co-authored-by: Connor <zbk602423539@gmail.com>
Co-authored-by: Bisheng Huang <hbisheng@gmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glorv glorv glorv approved these changes

@LykxSassinator LykxSassinator LykxSassinator approved these changes

+1 more reviewer

@mornyx mornyx mornyx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

Always keep reporting Already in CPU Profiling

6 participants

@Connor1996 @glorv @ti-chi-bot @LykxSassinator @mornyx @overvenus