Skip to content

profiling: Fix cpu profiling flag may not reset when meeting errors (#17235)#17825

Merged
ti-chi-bot[bot] merged 4 commits intotikv:release-7.5from
ti-chi-bot:cherry-pick-17235-to-release-7.5
Dec 13, 2024
Merged

profiling: Fix cpu profiling flag may not reset when meeting errors (#17235)#17825
ti-chi-bot[bot] merged 4 commits intotikv:release-7.5from
ti-chi-bot:cherry-pick-17235-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 14, 2024

This is an automated cherry-pick of #17235

What is changed and how it works?

Issue Number: Close #17234

What's Changed:

Fix cpu profiling flag may not reset when meeting errors

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fix the issue that CPU Profiling doesn't work reporting `Already in CPU Profiling`

@Connor1996 @ti-chi-bot
This is an automated cherry-pick of tikv#17235
7c709f0 
close tikv#17234

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 14, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 14, 2024
Merged
9 tasks
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 2, 2024
@hbisheng
Fix import conflict
08cc91d 
Signed-off-by: Bisheng Huang <hbisheng@gmail.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 10, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbisheng, LykxSassinator

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 13, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-10 05:50:43.099596321 +0000 UTC m=+331233.188398867: ☑️ agreed by hbisheng.
  • 2024-12-13 02:02:46.792399527 +0000 UTC m=+576756.881202055: ☑️ agreed by LykxSassinator.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 13, 2024

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@LykxSassinator
Copy link
Contributor

LykxSassinator commented Dec 13, 2024

/retest

1 similar comment
@Connor1996
Copy link
Member

Connor1996 commented Dec 13, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit ad7e997 into tikv:release-7.5 Dec 13, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2024

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test b2e5f53 link true /test pull-unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LykxSassinator LykxSassinator LykxSassinator approved these changes

+1 more reviewer

@hbisheng hbisheng hbisheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Connor1996 Connor1996

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @LykxSassinator @Connor1996 @hbisheng