engine: only override write stall configurations if unspecified#12127
engine: only override write stall configurations if unspecified#12127ti-chi-bot merged 9 commits intotikv:masterfrom
Conversation
Signed-off-by: tabokie <xy.tao@outlook.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
Signed-off-by: tabokie <xy.tao@outlook.com>
…rride Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
…rride Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie <xy.tao@outlook.com>
| Some($cfg.l0_files_threshold as i32); | ||
| } | ||
| if let Some(v) = &mut $cf_opts.level0_stop_writes_trigger { | ||
| if $cfg.enable && *v > $cfg.l0_files_threshold as i32 { |
There was a problem hiding this comment.
no need to check stop_writes_trigger
There was a problem hiding this comment.
Why, I remember stop is allowed to be smaller than slow, in which case RocksDB will modify slow to match stop.
| pub disable_write_stall: bool, | ||
| pub soft_pending_compaction_bytes_limit: ReadableSize, | ||
| pub hard_pending_compaction_bytes_limit: ReadableSize, | ||
| pub soft_pending_compaction_bytes_limit: Option<ReadableSize>, |
There was a problem hiding this comment.
what's the output of Option after serialization
There was a problem hiding this comment.
None will not be serialized, Some is serialized in the same way as normal fields.
|
/merge |
|
@tabokie: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: ca7199a |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.2 in PR #12733 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.3 in PR #12734 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.4 in PR #12735 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-6.0 in PR #12736 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-6.1 in PR #12737 |
…#12127) ref tikv#11424, ref tikv#11840 Signed-off-by: tabokie <xy.tao@outlook.com>
Signed-off-by: tabokie xy.tao@outlook.com
What is changed and how it works?
Issue Number: Ref #11424
What's Changed:
Follow up on #11840.
This is handy if we want to make RocksDB compaction a bit faster without triggering flow control.
Related changes
Check List
Tests
Release note