Skip to content

engine: only override write stall configurations if unspecified (#12127)#12735

Merged
ti-chi-bot merged 3 commits intotikv:release-5.4from
ti-srebot:release-5.4-2a508a583c52
Sep 15, 2022
Merged

engine: only override write stall configurations if unspecified (#12127)#12735
ti-chi-bot merged 3 commits intotikv:release-5.4from
ti-srebot:release-5.4-2a508a583c52

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 2, 2022 •
edited by tabokie
Loading

cherry-pick #12127 to release-5.4
You can switch your code base to this Pull Request by using git-extras:

# In tikv repo:
git pr https://github.com/tikv/tikv/pull/12735

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tikv.git pr/12735:release-5.4-2a508a583c52

Signed-off-by: tabokie xy.tao@outlook.com

What is changed and how it works?

Issue Number: Close #13467, Ref #11424

What's Changed:

Follow up on #11840.

This is handy if we want to make RocksDB compaction a bit faster without triggering flow control.

Related changes

  • Doc change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note 

None

@tabokie @ti-srebot
cherry pick tikv#12127 to release-5.4
21c7c3d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tabokie
  • zhangjinpeng1987

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 2, 2022
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jun 2, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 2, 2022
@ti-srebot ti-srebot mentioned this pull request Jun 2, 2022
Merged
@ti-srebot ti-srebot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick Type: PR - Cherry pick labels Jun 2, 2022
@ti-srebot ti-srebot requested a review from Connor1996 June 2, 2022 02:34
@ti-srebot ti-srebot added this to the v5.4.1 milestone Jun 2, 2022
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jun 2, 2022

@tabokie you're already a collaborator in bot's repo.

tabokie
tabokie reviewed Jun 2, 2022
View reviewed changes
tabokie
tabokie reviewed Jun 2, 2022
View reviewed changes
@tabokie
Apply suggestions from code review
212784e 
Signed-off-by: Xinye Tao <xy.tao@outlook.com>
tabokie
tabokie approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@tabokie tabokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on #12738.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2022
zhangjinpeng87
zhangjinpeng87 approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 6, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 15, 2022
@tabokie
Copy link
Member

tabokie commented Sep 15, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 15, 2022

@tabokie: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 15, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b9ca5b1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 15, 2022
@ti-chi-bot ti-chi-bot merged commit 98b137f into tikv:release-5.4 Sep 15, 2022
@tabokie tabokie deleted the release-5.4-2a508a583c52 branch September 15, 2022 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhangjinpeng87 zhangjinpeng87 zhangjinpeng87 approved these changes

@tabokie tabokie tabokie approved these changes

@Connor1996 Connor1996 Awaiting requested review from Connor1996

Assignees

@tabokie tabokie

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick Type: PR - Cherry pick

Projects

None yet

Milestone

v5.4.1

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-srebot @ti-chi-bot @tabokie @zhangjinpeng87 @VelocityLight