api: add status query parameter for the scheduler API#3055
Merged
ti-srebot merged 3 commits intotikv:masterfrom Oct 10, 2020
Merged
api: add status query parameter for the scheduler API#3055ti-srebot merged 3 commits intotikv:masterfrom
ti-srebot merged 3 commits intotikv:masterfrom
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
disksing
reviewed
Oct 9, 2020
server/api/scheduler.go
Outdated
| return | ||
| default: | ||
| } | ||
| h.r.JSON(w, http.StatusOK, schedulers) |
Contributor
There was a problem hiding this comment.
move this line after default:?
server/api/scheduler.go
Outdated
| status := r.URL.Query().Get("status") | ||
| switch status { | ||
| case "paused": | ||
| var pausedScehdulers []string |
Contributor
There was a problem hiding this comment.
Suggested change
| var pausedScehdulers []string | |
| var pausedSchedulers []string |
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Contributor
|
LGTM |
disksing
approved these changes
Oct 10, 2020
| } | ||
| } | ||
| h.r.JSON(w, http.StatusOK, pausedSchedulers) | ||
| return |
ti-srebot
approved these changes
Oct 10, 2020
Contributor
|
/merge |
Contributor
|
/run-all-tests |
Contributor
|
cherry pick to release-4.0 in PR #3066 |
rleungx
added a commit
to ti-srebot/pd
that referenced
this pull request
Oct 13, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-srebot
added a commit
that referenced
this pull request
Oct 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Closes #3052.
What is changed and how it works?
This PR supports the status query parameter for the scheduler API. For now, it only supports the
pausedstatus. If there is no status query parameter, the default behavior is the same as before.Check List
Tests
Release note