Skip to content

api: add status query parameter for the scheduler API (#3055)#3066

Merged
ti-srebot merged 2 commits intotikv:release-4.0from
ti-srebot:release-4.0-858ef8c322a9
Oct 15, 2020
Merged

api: add status query parameter for the scheduler API (#3055)#3066
ti-srebot merged 2 commits intotikv:release-4.0from
ti-srebot:release-4.0-858ef8c322a9

Conversation

@ti-srebot
Copy link
Contributor

cherry-pick #3055 to release-4.0


What problem does this PR solve?

Closes #3052.

What is changed and how it works?

This PR supports the status query parameter for the scheduler API. For now, it only supports the paused status. If there is no status query parameter, the default behavior is the same as before.

Check List

Tests

  • Manual test

Release note

@rleungx
Copy link
Member

rleungx commented Oct 13, 2020

/run-all-tests

Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to return.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please solve the comment

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx force-pushed the release-4.0-858ef8c322a9 branch from db9c7d5 to de12647 Compare October 13, 2020 12:24
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Oct 14, 2020
@nolouch
Copy link
Contributor

nolouch commented Oct 15, 2020

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 15, 2020
@nolouch
Copy link
Contributor

nolouch commented Oct 15, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 15, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@rleungx
Copy link
Member

rleungx commented Oct 15, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@rleungx
Copy link
Member

rleungx commented Oct 15, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 31de6d7 into tikv:release-4.0 Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/api HTTP API. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants