manager: hide root related features if kernelsu not available#2555
Conversation
|
You can create a Composable component that accepts another component. If the ksu is valid, the component will be displayed; if it is invalid, nothing will happen. This way, you can wrap any component without needing to write |
Okay, let me try |
tiann#2555 (comment) Signed-off-by: Faris <90097027+rsuntk@users.noreply.github.com>
Can you review the changes? |
Result
|
tiann#2555 (comment) Signed-off-by: Faris <90097027+rsuntk@users.noreply.github.com>
Without KernelSU installed, root-related features did not take any effect. So, better to hide it. Improving this pr: #2483 Also attempt to address this: #2483 (comment) Tested-by: Faris <90097027+rsuntk@users.noreply.github.com> Signed-off-by: Faris <90097027+rsuntk@users.noreply.github.com> Co-authored-by: Rifat Azad <33044977+rifsxd@users.noreply.github.com>
Addressing this: #2555 (comment) Signed-off-by: Faris <90097027+rsuntk@users.noreply.github.com>
Signed-off-by: Faris <90097027+rsuntk@users.noreply.github.com>
|
Ready to merge. |
tiann#2555 (comment) Signed-off-by: Faris <90097027+rsuntk@users.noreply.github.com>
tiann#2555 (comment) Signed-off-by: Faris <90097027+rsuntk@users.noreply.github.com>
* 'main' of https://github.com/tiann/KernelSU: manager: hide root related features if kernelsu not available (tiann#2555) Change-Id: Iad1d443a2482e1b5bdb52e5accdef695bb840e7d
Without KernelSU installed, root-related features did not take any effect. So, better to hide it.
Improving this pr:
#2483
Also attempt to address this:
#2483 (comment)
Tested-by: Faris 90097027+rsuntk@users.noreply.github.com
Co-authored-by: Rifat Azad 33044977+rifsxd@users.noreply.github.com