hide root related features if kernelsu is not installed (if ksuversion is null)#2483
Closed
rifsxd wants to merge 6 commits into
Closed
hide root related features if kernelsu is not installed (if ksuversion is null)#2483rifsxd wants to merge 6 commits into
rifsxd wants to merge 6 commits into
Conversation
…ksuversion is null)
Contributor
Author
|
my bad.. only commit 5215357 is relevant in this PR |
Contributor
Author
|
should've used a sperate clean branch 😅 |
Owner
|
Please consider creating a component to wrap it, as there is a lot of boilerplate code. |
Contributor
Author
|
Will come back to this after a few days later |
rsuntk
added a commit
to rsuntk/KernelSU
that referenced
this pull request
Apr 18, 2025
Related PR: tiann#2483 Also attempting to address this: tiann#2483 (comment) Signed-off-by: rsuntk <rsuntk@yukiprjkt.my.id>
Contributor
Author
|
Closing this PR since better implementation is being carried on in #2555 |
tiann
pushed a commit
that referenced
this pull request
May 3, 2025
Without KernelSU installed, root-related features did not take any effect. So, better to hide it. Improving this pr: #2483 Also attempt to address this: #2483 (comment) Tested-by: Faris <90097027+rsuntk@users.noreply.github.com> Co-authored-by: Rifat Azad <33044977+rifsxd@users.noreply.github.com> --------- Signed-off-by: Faris <90097027+rsuntk@users.noreply.github.com> Co-authored-by: Rifat Azad <33044977+rifsxd@users.noreply.github.com>
rsuntk
added a commit
to rsuntk/KernelSU
that referenced
this pull request
May 9, 2025
Related PR: tiann#2483 Also attempting to address this: tiann#2483 (comment) Signed-off-by: rsuntk <rsuntk@yukiprjkt.my.id>
rsuntk
added a commit
to rsuntk/KernelSU
that referenced
this pull request
May 9, 2025
Related PR: tiann#2483 Also attempting to address this: tiann#2483 (comment) Signed-off-by: rsuntk <rsuntk@yukiprjkt.my.id>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HIde features that are irrelevant/broken if kernelsu is not installed