Improve DM test functionality on Windows, fix regressions#221
Merged
ZeWaka merged 3 commits intotgstation:masterfrom Jun 18, 2025
Merged
Improve DM test functionality on Windows, fix regressions#221ZeWaka merged 3 commits intotgstation:masterfrom
ZeWaka merged 3 commits intotgstation:masterfrom
Conversation
Collaborator
|
Awesome will review, CI broken because, byond |
ZeWaka
approved these changes
Jun 4, 2025
itsmeow
added a commit
to BeeStation/rust-g
that referenced
this pull request
Feb 26, 2026
itsmeow
added a commit
to BeeStation/rust-g
that referenced
this pull request
Feb 26, 2026
* fixes the clippy lints on nightly (tgstation#215) * Adds a new time function, `formatted_timestamp` (tgstation#214) * dmi_create_png is rgba instead of rgb (tgstation#217) * add useragent to byond installer * crate internal updates (tgstation#218) * v3.9.0 (tgstation#219) * Enable pathfinder by default (tgstation#220) * Fix clippy URL lifetime lint (tgstation#223) * Improve DM test functionality on Windows, fix regressions (tgstation#221) * Adds `roll_dice`, an advanced xdy dice roller. (tgstation#216) Co-authored-by: Kapu1178 <75460809+Kapu1178@users.noreply.github.com> * v3.11.0 (tgstation#224) * Fix TOML dme test failing (tgstation#227) * hash: optimize file hashing (tgstation#228) * IconForge: DMI Generation, Code Reorganization, Improved Caching, Cleaner I/O (tgstation#213) * Adds a new `uuid` module (tgstation#229) * IconForge: BYOND Parity + Tests, Optimizations, New Transforms (tgstation#230) * `clippy` lints for tgstation#230 (tgstation#233) * Adds `http_request_fire_and_forget` (tgstation#232) * DMI metadata reading and injection (tgstation#234) * 4.0.0 (tgstation#235) * dmi: Add QR code generation (tgstation#226) * Bump `dmi` to 0.5.0, optimize `dmi_read_metadata` (tgstation#238) * Update CI to target 516.1666 (tgstation#237) * 4.1.0 (tgstation#239) * makes `rustg_noise_poisson_map` around 8x faster (tgstation#240) * IconForge: Headless Icon Generation (tgstation#236) * `cargo update` & `cargo upgrade` & `png` fix (tgstation#241) * assorted optimizations to `cellularnoise`, `dbpnoise`, and `worleynoise` (tgstation#243) * v4.2.0 (tgstation#242) * Fix attempt for CI * hash: Adds ChaCha20 CSPRNG functions, updates TOTP generator, adds Base32 (tgstation#225) * Handle errors in panic hook explicitly (tgstation#245) * do not store Git information static (tgstation#247) * Prevent `decode_base64` and `decode_base32` from panicking if given invalid base64 (tgstation#244) * 4.3.0 (tgstation#249) * fix iconforge generate_headless on win for bad paths not panicing (tgstation#248) * 5.0.0 (tgstation#250) * redo iconforge errors - 5.0.1 (tgstation#252) * 6.0.0 - drop windows 7 support (tgstation#251) * fix spritesheet gen on linux (tgstation#255) * cargo update and clippy (tgstation#253) * 6.0.1 - and `cargo update` (tgstation#256) --------- Co-authored-by: Lucy <lucy@absolucy.moe> Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com> Co-authored-by: ZeWaka <zewakagamer@gmail.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Co-authored-by: Comrade Niobe <126028983+ComradeNiobe@users.noreply.github.com> Co-authored-by: Kapu1178 <75460809+Kapu1178@users.noreply.github.com> Co-authored-by: Y0SH1M4S73R <y0sh1m4s73r@gmail.com> Co-authored-by: Ivy <distributivgesetz93@gmail.com> Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com> Co-authored-by: Kashargul <144968721+Kashargul@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
byondexecdoes not exist on windows, and the test runner initializesbashunnecessarily. We can now use thedmandddbinaries directly for better CLI support on Windows. I've also added basic path detection for windows install directories to allow tests to be run directly from VSCode.All the DM tests run with the rustg repository folder as the main directory, rather than the folder containing the DME. This is counterintuitive and breaks compile->runtime RSC paths for icons, because the change-directory does not apply to files with their paths stored in the RSC. I've added a flag to use the repository root (the previous behavior), currently only the git test uses it, because the git feature always uses
.as the repository path. I think the only reason the repathing was implemented in the first place was to support this test.Many tests leave files hanging around that aren't ignored by git, making local test runs problematic. I've added these files to the gitignore and made a
tmp/directory for use by the tests.abc-testsseems to have a regression on Windows where the regex matches the native TLS block and causes an error. Excluding#from the list of allowed characters fixes it.I also took the liberty of moving some of the DM test code into functions and generally just making it cleaner, since it hasn't been improved properly since 2021.