fix: update test & ci to use the sync service#1353
Merged
laurentsenta merged 4 commits intomasterfrom Jun 14, 2022
Merged
Conversation
Member
|
@laurentsenta mind stating the motivation here for folks like me that are not too familiar with testground to be able to follow along? |
Contributor
Author
|
@mxinden I updated the description :) |
6ce526f to
e2847da
Compare
4 tasks
laurentsenta
added a commit
that referenced
this pull request
Jun 10, 2022
Squashed commit of the following: commit e2847da Author: Laurent Senta <laurent@singulargarden.com> Date: Thu Jun 9 10:43:38 2022 +0200 fix: converstion error in k8s ``` Jun 9 08:39:50.154528 INFO cleaning up finished pods... {"runner": "cluster:k8s", "run_id": "cagr3jtah42asoqjl390"} panic: interface conversion: runtime.Object is *v1.Status, not *v1.Event goroutine 105 [running]: github.com/testground/testground/pkg/runner.(*ClusterK8sRunner).watchRunPods.func1(0xc000d89980, 0xc0003d0700, 0xc0005ff020, 0xc000b864c0) /home/circleci/project/pkg/runner/cluster_k8s.go:736 +0x4a9 created by github.com/testground/testground/pkg/runner.(*ClusterK8sRunner).watchRunPods /home/circleci/project/pkg/runner/cluster_k8s.go:734 +0x2e7 ``` commit a53077f Author: Laurent Senta <laurent@singulargarden.com> Date: Wed Jun 8 18:26:08 2022 +0200 ci: tweak the configuration so sync service passes commit f2ab852 Author: Laurent Senta <laurent@singulargarden.com> Date: Wed Jun 8 17:34:34 2022 +0200 fix: minimal init the placebo test commit b6d65c2 Author: Laurent Senta <laurent@singulargarden.com> Date: Wed Jun 8 12:49:05 2022 +0200 fix: placebo examples relies on initialized test
brdji
approved these changes
Jun 10, 2022
Contributor
Author
|
@brdji coming from discord, have you had a chance to ask some of the k8s experts on your team for a review? |
```
Jun 9 08:39:50.154528 INFO cleaning up finished pods...
{"runner": "cluster:k8s", "run_id": "cagr3jtah42asoqjl390"}
panic: interface conversion: runtime.Object is *v1.Status, not *v1.Event
goroutine 105 [running]:
github.com/testground/testground/pkg/runner.(*ClusterK8sRunner).watchRunPods.func1(0xc000d89980,
0xc0003d0700, 0xc0005ff020, 0xc000b864c0)
/home/circleci/project/pkg/runner/cluster_k8s.go:736 +0x4a9
created by
github.com/testground/testground/pkg/runner.(*ClusterK8sRunner).watchRunPods
/home/circleci/project/pkg/runner/cluster_k8s.go:734 +0x2e7
```
e2847da to
40bed76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're patching
testground run --waitto make the CLI exit code consistent with the testground outcome in #1347. We want to make sure that if the test outcome is a failure, the command fails.But now, integrations tests in #1347 fail because the
placebotest outcome isfailure(see comments in #1304 for more details) and the CLI catches this outcome (which is the new, expected, behavior).Todo