fix: testground run with --wait exits with code = 0 on some failures#1347
Merged
laurentsenta merged 17 commits intomasterfrom Jun 20, 2022
Merged
fix: testground run with --wait exits with code = 0 on some failures#1347laurentsenta merged 17 commits intomasterfrom
laurentsenta merged 17 commits intomasterfrom
Conversation
c37835e to
aed4473
Compare
Contributor
Author
|
I'll revisit #1321 when we approve & merge this. |
7413012 to
d3b752f
Compare
3 tasks
Contributor
Author
|
( |
b2e558c to
d7ed2e6
Compare
d7ed2e6 to
15cc3d6
Compare
15cc3d6 to
0555a78
Compare
0555a78 to
6899d2c
Compare
brdji
reviewed
Jun 17, 2022
brdji
approved these changes
Jun 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1349
Contributes to #1304
Context:
Testground defines a
task.Taskobject with an anonymous Result field. The content of this field depends on the builder or runner used, for example:That's fine for storage / serialization (when used as a wire format), but any piece of code that "receive" a task object needs to interpret the
Resultfield by knowing about the runners. There are hints of the code required in thedaemon/tasks.gocode, see related PR: #1321. It create cyclic dependencies and bugs (because not all parts of the code use the same interpretation, see issue #1349).Later it would be nice to rethink this data model.
Tasks
data.DecodeTaskOutcomefunction, (a non-intrusive way to make sure we have ONE reusable way to compute task outcomes),--waitwill fail with exit code != 0 if the outcome is not a success.