fix: builder result parsing in web server#1321
Merged
laurentsenta merged 1 commit intomasterfrom Jul 7, 2022
Merged
Conversation
b4b3c62 to
db79234
Compare
laurentsenta
commented
Apr 22, 2022
Contributor
Author
|
Done |
4 tasks
db79234 to
f5d5b28
Compare
laurentsenta
commented
Jun 28, 2022
| return fmt.Sprintf("%s:%s", t.Plan, t.Case) | ||
| default: | ||
| return "not supported" | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Note: I can't decode the BuildInput here and show something more precise in place of "build". There is a cycle between api and the task package. Will revisit with a larger refactoring later.
brdji
approved these changes
Jul 5, 2022
f5d5b28 to
e726fc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1320
Retrieve the task outcome using the decoder from #1347, generates the correct outcome during builds.