feat(redis): add TLS support#3115
Merged
mdelapenya merged 33 commits intotestcontainers:mainfrom Apr 24, 2025
Merged
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
commented
Apr 17, 2025
gaby
reviewed
Apr 21, 2025
gaby
reviewed
Apr 21, 2025
mdelapenya
commented
Apr 22, 2025
mdelapenya
commented
Apr 22, 2025
mdelapenya
commented
Apr 22, 2025
For more advanced use cases, please use the different functional options to override the CMD or the Entrypoint
stevenh
requested changes
Apr 22, 2025
We were overriding the default CMD, when the image is not defining an entrypoint. So we were not honouring the entrypoint.sh script in the stack images
mdelapenya
commented
Apr 22, 2025
mdelapenya
commented
Apr 22, 2025
stevenh
requested changes
Apr 22, 2025
Contributor
stevenh
left a comment
There was a problem hiding this comment.
Just some comment formatting
stevenh
requested changes
Apr 22, 2025
Contributor
stevenh
left a comment
There was a problem hiding this comment.
Sorry to be a pain, but looks like this can be simplified quite a bit.
* main: feat: add toxiproxy module (testcontainers#3092) chore(ci): run core tests on Testcontainers Cloud (testcontainers#3117)
stevenh
requested changes
Apr 23, 2025
Contributor
stevenh
left a comment
There was a problem hiding this comment.
Just a couple of changes and then I think we're good.
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Apr 24, 2025
* main: feat(redis): add TLS support (testcontainers#3115) feat: add Docker Model Runner module (testcontainers#3106) feat: add toxiproxy module (testcontainers#3092) chore(ci): run core tests on Testcontainers Cloud (testcontainers#3117) deps(aerospike): replace core module in go.mod (testcontainers#3116) chore(deps): bump golang.org/x/net from 0.36.0 to 0.38.0 in /modules and /examples (testcontainers#3114) chore(ci): revert codeql improvements for CI resiliency (testcontainers#3112) docs(socat): add missing version marker for new options (testcontainers#3111)
mdelapenya
added a commit
to xBlaz3kx/testcontainers-go
that referenced
this pull request
Apr 24, 2025
* main: feat(postgres): add WithOrderedInitScripts for Postgres testcontainers (testcontainers#3121) feat(redis): add TLS support (testcontainers#3115) feat: add Docker Model Runner module (testcontainers#3106) feat: add toxiproxy module (testcontainers#3092) chore(ci): run core tests on Testcontainers Cloud (testcontainers#3117) deps(aerospike): replace core module in go.mod (testcontainers#3116) chore(deps): bump golang.org/x/net from 0.36.0 to 0.38.0 in /modules and /examples (testcontainers#3114) chore(ci): revert codeql improvements for CI resiliency (testcontainers#3112) docs(socat): add missing version marker for new options (testcontainers#3111) deps: use pinned dependencies on GH actions (testcontainers#3110) chore(deps): bump jinja2 from 3.1.5 to 3.1.6 (testcontainers#3109) chore(ci): reduce GH runners usage by calling codeql in the lint stage (testcontainers#3108) deps(ci): use python 3.13 on Netlify deployments (testcontainers#3107)
mdelapenya
added a commit
to jm96441n/testcontainers-go
that referenced
this pull request
Apr 24, 2025
* main: feat(postgres): add WithOrderedInitScripts for Postgres testcontainers (testcontainers#3121) feat(redis): add TLS support (testcontainers#3115) feat: add Docker Model Runner module (testcontainers#3106) feat: add toxiproxy module (testcontainers#3092) chore(ci): run core tests on Testcontainers Cloud (testcontainers#3117) deps(aerospike): replace core module in go.mod (testcontainers#3116) chore(deps): bump golang.org/x/net from 0.36.0 to 0.38.0 in /modules and /examples (testcontainers#3114) chore(ci): revert codeql improvements for CI resiliency (testcontainers#3112) docs(socat): add missing version marker for new options (testcontainers#3111)
mdelapenya
added a commit
to georgespalding/testcontainers-go
that referenced
this pull request
Apr 25, 2025
* main: feat(postgres): add WithOrderedInitScripts for Postgres testcontainers (testcontainers#3121) feat(redis): add TLS support (testcontainers#3115) feat: add Docker Model Runner module (testcontainers#3106) feat: add toxiproxy module (testcontainers#3092) chore(ci): run core tests on Testcontainers Cloud (testcontainers#3117) deps(aerospike): replace core module in go.mod (testcontainers#3116)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds TLS support for Redis, using https://github.com/mdelapenya/tlscert to generate certs on the fly.
The module will use a temporary dir in the OS to create the TLS certs, passing their bytes to the container. Finally, the module will store a TLS config for client code to build a secure client using that config.
Why is it important?
More advanced scenarios for Redis.
Follow-ups
Do we want users to contribute their own TLS certificates, or is it fine if the module generates them on the fly?