fix: never cache JSON representation of a container#2606
Merged
mdelapenya merged 7 commits intotestcontainers:mainfrom Jul 2, 2024
Merged
fix: never cache JSON representation of a container#2606mdelapenya merged 7 commits intotestcontainers:mainfrom
mdelapenya merged 7 commits intotestcontainers:mainfrom
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Not using fixed ports is good
* main: chore(deps): bump github.com/docker/docker from v26.1.4 to v27.0.2 (testcontainers#2593) fix: Rename TC_HOST environment variable to TESTCONTAINERS_HOST_OVERRIDE (testcontainers#2536) chore: test cleanups (testcontainers#2608) chore(ci): pass docker install type to the nightly build payload (testcontainers#2612) chore: run rootless mode in nighlty builds (testcontainers#2611) chore(deps): bump github.com/hashicorp/go-retryablehttp (testcontainers#2605) chore: improve log handling when container is stopping (testcontainers#2601)
mdelapenya
added a commit
that referenced
this pull request
Jul 2, 2024
* main: fix: never cache JSON representation of a container (#2606) chore: remove most uses of TestcontainersConfig and deprecated TestcontainersConfig fields. (#2614) chore(deps): bump github.com/docker/docker from v27.0.2 to v27.0.3 (#2615) chore(deps): bump github.com/docker/docker from v26.1.4 to v27.0.2 (#2593)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We are removing the raw attribute of the container, so we are not caching it when calling the Inspect method of a container.
At the same time, a container will wait for all the exposed ports to be available from the Docker representation for the container.
Why is it important?
There are cases where Docker or the container runtime is not updating the mapped ports by the time testcontainers uses them. Here we are fixing them.
Related issues
Follow-ups
We probably need a way to cache again the response, but we can decide how in a follow-up. Returning to pre-#2534 seems convenient until then.