fix: Rename TC_HOST environment variable to TESTCONTAINERS_HOST_OVERRIDE#2536
Merged
mdelapenya merged 4 commits intotestcontainers:mainfrom Jun 28, 2024
Merged
fix: Rename TC_HOST environment variable to TESTCONTAINERS_HOST_OVERRIDE#2536mdelapenya merged 4 commits intotestcontainers:mainfrom
mdelapenya merged 4 commits intotestcontainers:mainfrom
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hanapedia
commented
May 8, 2024
mdelapenya
approved these changes
Jun 28, 2024
Member
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM, thanks for checking the issue and providing a fix 🙇
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Jul 2, 2024
* main: chore(deps): bump github.com/docker/docker from v26.1.4 to v27.0.2 (testcontainers#2593) fix: Rename TC_HOST environment variable to TESTCONTAINERS_HOST_OVERRIDE (testcontainers#2536) chore: test cleanups (testcontainers#2608) chore(ci): pass docker install type to the nightly build payload (testcontainers#2612) chore: run rootless mode in nighlty builds (testcontainers#2611) chore(deps): bump github.com/hashicorp/go-retryablehttp (testcontainers#2605) chore: improve log handling when container is stopping (testcontainers#2601)
mdelapenya
added a commit
that referenced
this pull request
Jul 2, 2024
* main: fix: Rename TC_HOST environment variable to TESTCONTAINERS_HOST_OVERRIDE (#2536)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rename
TC_HOSTenvironment variable toTESTCONTAINERS_HOST_OVERRIDEto align with other testcontainers projects.Why is it important?
The changes in this PR will align how to override the host of the docker daemon where the container port is exposed with other testcontainers projects and the current
testcontainers-godocumentation.In other testcontainers projects,
TESTCONTAINERS_HOST_OVERRIDEenvironment variable is used to override host of the docker daemon where the container port is exposed.testcontainers-gomentions this environment variable in the documentation but it is currently not implemented. Instead,testcontainers-gousesTC_HOST, which is the old envrionment variable used in other projects for the same purpose.Related issues
Follow-ups
The changes in this PR will deprecate
TC_HOSTenvironment variable.