Skip to content

the correct argument is "--output_image"#17430

Closed
tjeckleburg wants to merge 1 commit intotensorflow:masterfrom
tjeckleburg:patch-1
Closed

the correct argument is "--output_image"#17430
tjeckleburg wants to merge 1 commit intotensorflow:masterfrom
tjeckleburg:patch-1

Conversation

@tjeckleburg
Copy link
Copy Markdown

@tjeckleburg tjeckleburg commented Mar 5, 2018 •
edited
Loading

It looks like the correct argument name is "--output_image". I got the following error when I ran it with "--output_png":

INFO: Running command line: bazel-bin/tensorflow/examples/wav_to_spectrogram/wav_to_spectrogram '--input_wav=/tmp/speech_dataset/happy/ab00c4b2_nohash_0.wav' '--output_png=/tmp/spectrogram.png'
2018-03-04 23:47:22.532841: E tensorflow/examples/wav_to_spectrogram/main.cc:54] Unknown argument --output_png=/tmp/spectrogram.png
usage: /private/var/tmp/_bazel_hakaydin/12fe9c53feea8848ab5cfab4ea3dcd47/execroot/org_tensorflow/bazel-out/darwin-py3-opt/bin/tensorflow/examples/wav_to_spectrogram/wav_to_spectrogram
Flags:
	--input_wav="tensorflow/core/kernels/spectrogram_test_data/short_test_segment.wav"	string	audio file to load
	--window_size=256                	int32	frequency sample window width
	--stride=128                     	int32	how far apart to place frequency windows
	--brightness=64.000000           	float	controls how bright the output image is
	--output_image="spectrogram.png" 	string	where to save the spectrogram image to

ERROR: Non-zero return code '255' from command: Process exited with status 255

@tjeckleburg
the correct argument is "--output_image"
8d35305 
You get the following error when you run it with "--output_png":
```
INFO: Running command line: bazel-bin/tensorflow/examples/wav_to_spectrogram/wav_to_spectrogram '--input_wav=/tmp/speech_dataset/happy/ab00c4b2_nohash_0.wav' '--output_png=/tmp/spectrogram.png'
2018-03-04 23:47:22.532841: E tensorflow/examples/wav_to_spectrogram/main.cc:54] Unknown argument --output_png=/tmp/spectrogram.png
usage: /private/var/tmp/_bazel_hakaydin/12fe9c53feea8848ab5cfab4ea3dcd47/execroot/org_tensorflow/bazel-out/darwin-py3-opt/bin/tensorflow/examples/wav_to_spectrogram/wav_to_spectrogram
Flags:
	--input_wav="tensorflow/core/kernels/spectrogram_test_data/short_test_segment.wav"	string	audio file to load
	--window_size=256                	int32	frequency sample window width
	--stride=128                     	int32	how far apart to place frequency windows
	--brightness=64.000000           	float	controls how bright the output image is
	--output_image="spectrogram.png" 	string	where to save the spectrogram image to

ERROR: Non-zero return code '255' from command: Process exited with status 255
```
@googlebot
Copy link
Copy Markdown

googlebot commented Mar 5, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@tjeckleburg
Copy link
Copy Markdown
Author

tjeckleburg commented Mar 5, 2018

I signed it.

@frankchn frankchn added the kokoro:force-run Tests on submitted change label Mar 15, 2018
@kokoro-team kokoro-team removed kokoro:force-run Tests on submitted change labels Mar 15, 2018
@frankchn
Copy link
Copy Markdown
Contributor

frankchn commented Mar 15, 2018

@tjeckleburg Can you check again? You might need to sign it with the email you made your commits in.

@gunan
Copy link
Copy Markdown
Contributor

gunan commented Jun 4, 2018

Looks like CLA is still not signed.
Please re-send the PR, after modifying the commit author email to the one you signed the CLA with.
I will close the PR for now.

@gunan gunan closed this Jun 4, 2018
copybara-service bot pushed a commit that referenced this pull request Oct 1, 2024
@hsharsha @tensorflower-gardener
PR #17430: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client
96f5415 
Imported from GitHub PR openxla/xla#17430

On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same
Copybara import of the project:

--
80eb83068d89982a743a69f83af9f351d6a829d6 by Harsha HS <Harsha.HavanurShamsundara@amd.com>:

[ROCm] Use unique_ptr for TupleHandle in pjrt_se_client

On older gcc (specifically in Ubuntu-20.04) and absl copy operator
fails to copy created TupleHandle into an existing variable.
Instead use unique_ptr to accompalish the same

Merging this change closes #17430

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17430 from ROCm:ci_use_shared_ptr_20240920 80eb83068d89982a743a69f83af9f351d6a829d6
PiperOrigin-RevId: 680653976
@copybara-service copybara-service bot mentioned this pull request Oct 1, 2024
Merged
copybara-service bot pushed a commit that referenced this pull request Oct 1, 2024
@hsharsha @tensorflower-gardener
PR #17430: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client
270467c 
Imported from GitHub PR openxla/xla#17430

On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same
Copybara import of the project:

--
80eb83068d89982a743a69f83af9f351d6a829d6 by Harsha HS <Harsha.HavanurShamsundara@amd.com>:

[ROCm] Use unique_ptr for TupleHandle in pjrt_se_client

On older gcc (specifically in Ubuntu-20.04) and absl copy operator
fails to copy created TupleHandle into an existing variable.
Instead use unique_ptr to accompalish the same

Merging this change closes #17430

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17430 from ROCm:ci_use_shared_ptr_20240920 80eb83068d89982a743a69f83af9f351d6a829d6
PiperOrigin-RevId: 680653976
copybara-service bot pushed a commit that referenced this pull request Oct 1, 2024
@hsharsha @tensorflower-gardener
PR #17430: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client
4688ce8 
Imported from GitHub PR openxla/xla#17430

On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same
Copybara import of the project:

--
80eb83068d89982a743a69f83af9f351d6a829d6 by Harsha HS <Harsha.HavanurShamsundara@amd.com>:

[ROCm] Use unique_ptr for TupleHandle in pjrt_se_client

On older gcc (specifically in Ubuntu-20.04) and absl copy operator
fails to copy created TupleHandle into an existing variable.
Instead use unique_ptr to accompalish the same

Merging this change closes #17430

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17430 from ROCm:ci_use_shared_ptr_20240920 80eb83068d89982a743a69f83af9f351d6a829d6
PiperOrigin-RevId: 680653976
copybara-service bot pushed a commit that referenced this pull request Oct 2, 2024
@hsharsha @tensorflower-gardener
PR #17430: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client
6a58166 
Imported from GitHub PR openxla/xla#17430

On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same
Copybara import of the project:

--
80eb83068d89982a743a69f83af9f351d6a829d6 by Harsha HS <Harsha.HavanurShamsundara@amd.com>:

[ROCm] Use unique_ptr for TupleHandle in pjrt_se_client

On older gcc (specifically in Ubuntu-20.04) and absl copy operator
fails to copy created TupleHandle into an existing variable.
Instead use unique_ptr to accompalish the same

Merging this change closes #17430

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17430 from ROCm:ci_use_shared_ptr_20240920 80eb83068d89982a743a69f83af9f351d6a829d6
PiperOrigin-RevId: 680653976
copybara-service bot pushed a commit that referenced this pull request Oct 2, 2024
@hsharsha @tensorflower-gardener
PR #17430: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client
be4f646 
Imported from GitHub PR openxla/xla#17430

On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same
Copybara import of the project:

--
80eb83068d89982a743a69f83af9f351d6a829d6 by Harsha HS <Harsha.HavanurShamsundara@amd.com>:

[ROCm] Use unique_ptr for TupleHandle in pjrt_se_client

On older gcc (specifically in Ubuntu-20.04) and absl copy operator
fails to copy created TupleHandle into an existing variable.
Instead use unique_ptr to accompalish the same

Merging this change closes #17430

PiperOrigin-RevId: 681556381
tensorflow-jenkins pushed a commit that referenced this pull request Oct 10, 2024
@hsharsha @tensorflow-jenkins
PR #17430: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client
8fca5e7 
Imported from GitHub PR openxla/xla#17430

On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same
Copybara import of the project:

--
80eb83068d89982a743a69f83af9f351d6a829d6 by Harsha HS <Harsha.HavanurShamsundara@amd.com>:

[ROCm] Use unique_ptr for TupleHandle in pjrt_se_client

On older gcc (specifically in Ubuntu-20.04) and absl copy operator
fails to copy created TupleHandle into an existing variable.
Instead use unique_ptr to accompalish the same

Merging this change closes #17430

PiperOrigin-RevId: 681556381
learning-to-play added a commit that referenced this pull request Oct 10, 2024
@learning-to-play
Merge pull request #77576 from tensorflow/r2.18-be4f646ec43
84c9398 
r2.18 cherry-pick: be4f646 "PR #17430: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@frankchn frankchn frankchn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: no

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tjeckleburg @googlebot @frankchn @gunan @kokoro-team